Bug 73521

Summary: [JSC] window.Option should be OptionConstructor
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, japhet, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73496, 73498    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2011-11-30 21:31:29 PST
This is a regression caused by a patch of bug 73307. If we replaced custom constructors of window.Audio and window.Option with the [NamedConstructor] IDL, fast/js/global-constructors.html, fast/dom/Window/window-properties.html and fast/dom/call-a-constructor-as-a-function.html start to fail in JSC. Before a patch of bug 73007: (correct) window.Audio => AudioConstructor window.Option => OptionConstructor window.HTMLAudioElement => HTMLAudioElementConstructor window.HTMLOptionElement => HTMLOptionElementConstructor After a patch of bug 73007: (wrong) window.Audio => HTMLAudioElementConstructor window.Option => HTMLOptionElementConstructor window.HTMLAudioElement => HTMLAudioElementConstructor window.HTMLOptionElement => HTMLOptionElementConstructor We should fix it.
Attachments
Patch (7.67 KB, patch)
2011-11-30 22:19 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-30 21:33:22 PST
(In reply to comment #0) > Before a patch of bug 73007: (correct) > After a patch of bug 73007: (wrong) Correction: s/bug 73007/bug 73307/
Kentaro Hara
Comment 2 2011-11-30 22:19:25 PST
Created attachment 117340 [details] Patch
WebKit Review Bot
Comment 3 2011-12-01 00:01:06 PST
Comment on attachment 117340 [details] Patch Clearing flags on attachment: 117340 Committed r101627: <http://trac.webkit.org/changeset/101627>
WebKit Review Bot
Comment 4 2011-12-01 00:01:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.