Bug 72215

Summary: Enable WebVTT parsing layout tests
Product: WebKit Reporter: Anna Cavender <annacc>
Component: MediaAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72369, 72398, 72399    
Bug Blocks: 43668    
Attachments:
Description Flags
Patch
none
Patch for landing none

Anna Cavender
Reported 2011-11-12 08:42:35 PST
Now that more <track> pieces are in place, we can enable the WebVTT parsing tests! A few little tweeks are required: (1) create a TextTrackCueList when TextTrack's cues() is called and (2) pay attention to chronological timestamp order requirement of WebVTT files. I'll include both small changes in with the patch.
Attachments
Patch (119.64 KB, patch)
2011-11-12 08:55 PST, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Patch for landing (120.12 KB, patch)
2011-11-12 15:15 PST, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2011-11-12 08:55:06 PST
Created attachment 114835 [details] Patch
Eric Carlson
Comment 2 2011-11-12 13:44:39 PST
Comment on attachment 114835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114835&action=review > LayoutTests/media/track/track-webvtt-tc000-empty.html:2 > +<html> > + <head> These are tests of an HTML5 feature, so they might as well have "<!DOCTYPE html>"
Eric Carlson
Comment 3 2011-11-12 13:59:29 PST
Comment on attachment 114835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114835&action=review > Source/WebCore/html/TextTrackCueList.cpp:86 > void TextTrackCueList::add(PassRefPtr<TextTrackCue> cue) > { > + // WebVTT cue timings > + // 1. The time represented by this WebVTT timestamp must be greater than or equal > + // to the start time offsets of all previous cues in the file. > + // http://www.whatwg.org/specs/web-apps/current-work/#webvtt-cue-timings > + // Note: because this requirement is specific to WebVTT, we may want to check first > + // whether the cues in this list came from a WebVTT file. This needs a layout test if we don't already have one.
Anna Cavender
Comment 4 2011-11-12 15:05:29 PST
Comment on attachment 114835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114835&action=review >> Source/WebCore/html/TextTrackCueList.cpp:86 >> + // whether the cues in this list came from a WebVTT file. > > This needs a layout test if we don't already have one. Yes, this is the one: track-webvtt-tc012-out-of-order.html >> LayoutTests/media/track/track-webvtt-tc000-empty.html:2 >> + <head> > > These are tests of an HTML5 feature, so they might as well have "<!DOCTYPE html>" Will do, thanks.
Anna Cavender
Comment 5 2011-11-12 15:15:36 PST
Created attachment 114844 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-11-12 16:48:15 PST
Comment on attachment 114844 [details] Patch for landing Clearing flags on attachment: 114844 Committed r100085: <http://trac.webkit.org/changeset/100085>
WebKit Review Bot
Comment 7 2011-11-12 16:48:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.