Bug 71983

Summary: Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, ossy, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176761
Bug Depends on: 71961, 73062    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2011-11-09 17:53:52 PST
Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
Attachments
Patch (21.51 KB, patch)
2011-11-09 17:54 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (19.80 KB, patch)
2011-11-23 15:15 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-11-09 17:54:53 PST
Created attachment 114414 [details] Patch
Eric Seidel (no email)
Comment 2 2011-11-09 18:04:04 PST
Once this is in, hopefully we can run the test-webkitpy tests on the commit-queue again, and we can get rid of the evironment overrides in start-queue.sh which are breaking the cq for folks with unicode names. :)
Adam Barth
Comment 3 2011-11-09 18:09:43 PST
Comment on attachment 114414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114414&action=review > Tools/Scripts/webkitpy/common/system/environment_mock.py:38 > + @classmethod > + def disable_gcc_smartquotes(self, env): I think you want the Host to vend your a mutable Environment object that has a getter that returns the env dictionary. The MockHost can then vend you a legit Environment object with a dictionary initialized to something independent of the actual environment.
Eric Seidel (no email)
Comment 4 2011-11-23 15:15:41 PST
Created attachment 116438 [details] Patch
Eric Seidel (no email)
Comment 5 2011-11-23 15:23:55 PST
Committed r101107: <http://trac.webkit.org/changeset/101107>
Eric Seidel (no email)
Comment 6 2011-11-23 16:20:41 PST
Adam: Would you try removing the envionment hack in the ews/cq servers now that this has landed?
Adam Barth
Comment 7 2011-11-23 16:57:01 PST
> Adam: Would you try removing the envionment hack in the ews/cq servers now that this has landed? Sure, although I'll probably wait until after Thanksgiving so I don't have to do any crisis management over the holiday weekend.
Eric Seidel (no email)
Comment 8 2011-11-28 09:01:41 PST
This got rolled out in bug 73062. Fixing now.
Eric Seidel (no email)
Comment 9 2011-11-28 11:00:13 PST
Committed r101266: <http://trac.webkit.org/changeset/101266>
Note You need to log in before you can comment on or make changes to this bug.