Summary: | Move the content of SelectElementData into HTMLSelectElement, and remove SelectElement.{cpp,h} | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | darin, gustavo.noronha, gustavo, rniwa, xan.lopez | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 69812 | ||||||||
Bug Blocks: | 69908 | ||||||||
Attachments: |
|
Description
Kent Tamura
2011-10-11 03:30:56 PDT
Created attachment 110493 [details]
Patch
Comment on attachment 110493 [details] Patch Attachment 110493 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10027494 Comment on attachment 110493 [details] Patch Attachment 110493 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10031417 Created attachment 110503 [details]
Patch 2
Probably fixed GTK and Windows bulid
Comment on attachment 110503 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=110503&action=review > Source/WebCore/html/HTMLSelectElement.h:164 > + bool usesMenuList() const > + { > +#if ENABLE(NO_LISTBOX_RENDERING) > + return true; > +#else > + return !m_multiple && m_size <= 1; > +#endif > + } It’s good to have this inline, but it’s a little long and ugly to have here in the class definition. I’d put it separately after the class definition. > Source/WebCore/html/HTMLSelectElement.h:178 > Vector<Element*> m_listItems; These should be HTMLFormControlElement*. The only reason they are Element* was WML support. > Source/WebCore/html/HTMLSelectElement.h:191 > bool m_recalcListItems; I think this should be renamed (later) m_shouldRecalcListItems or something even better. Comment on attachment 110503 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=110503&action=review >> Source/WebCore/html/HTMLSelectElement.h:164 >> + } > > It’s good to have this inline, but it’s a little long and ugly to have here in the class definition. I’d put it separately after the class definition. ok, I move it. >> Source/WebCore/html/HTMLSelectElement.h:178 >> Vector<Element*> m_listItems; > > These should be HTMLFormControlElement*. The only reason they are Element* was WML support. Unfortunately, m_listItems contains <hr> elements. We can change Element* to HTMLElement*. >> Source/WebCore/html/HTMLSelectElement.h:191 >> bool m_recalcListItems; > > I think this should be renamed (later) m_shouldRecalcListItems or something even better. I'll address this later. Committed r97238: <http://trac.webkit.org/changeset/97238> |