Cleanup of HTMLSelectElement
Created attachment 110657 [details] Patch
Comment on attachment 110657 [details] Patch Attachment 110657 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10026839
Created attachment 110658 [details] Patch 2 Fix Chromium build
Comment on attachment 110658 [details] Patch 2 Attachment 110658 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10032648
Created attachment 110660 [details] Patch 3 Fix Chromium build again
Comment on attachment 110660 [details] Patch 3 If you’re going to change the type, please change it to HTMLFormControlElement, not just HTMLElement. Unless maybe there was a reason you couldn’t do that?
Comment on attachment 110660 [details] Patch 3 I think the class is using the listItems() function too much internally with lots of local variables that have a reference to the list; this is leftover from where the list was in a separate object. I’d prefer a design where, inside the class, we call an explicit updateListItems function and then use m_listItems directly.
Comment on attachment 110660 [details] Patch 3 Attachment 110660 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10044039
(In reply to comment #6) > (From update of attachment 110660 [details]) > If you’re going to change the type, please change it to HTMLFormControlElement, not just HTMLElement. Unless maybe there was a reason you couldn’t do that? m_listItems contains <hr> elements. This behavior was introduced by http://trac.webkit.org/changeset/10433. I don't know this behavior is needed now.
Created attachment 110809 [details] Patch for landing Fix GTK build.
Comment on attachment 110809 [details] Patch for landing Clearing flags on attachment: 110809 Committed r97354: <http://trac.webkit.org/changeset/97354>
All reviewed patches have been landed. Closing bug.