Bug 69908 - Cleanup of HTMLSelectElement
Summary: Cleanup of HTMLSelectElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Minor
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 69828
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-12 00:19 PDT by Kent Tamura
Modified: 2011-10-13 02:07 PDT (History)
7 users (show)

See Also:


Attachments
Patch (40.24 KB, patch)
2011-10-12 03:09 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (40.44 KB, patch)
2011-10-12 03:37 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 3 (43.79 KB, patch)
2011-10-12 03:56 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch for landing (45.27 KB, patch)
2011-10-13 00:58 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-10-12 00:19:59 PDT
Cleanup of HTMLSelectElement
Comment 1 Kent Tamura 2011-10-12 03:09:10 PDT
Created attachment 110657 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-12 03:17:42 PDT
Comment on attachment 110657 [details]
Patch

Attachment 110657 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10026839
Comment 3 Kent Tamura 2011-10-12 03:37:23 PDT
Created attachment 110658 [details]
Patch 2

Fix Chromium build
Comment 4 WebKit Review Bot 2011-10-12 03:44:29 PDT
Comment on attachment 110658 [details]
Patch 2

Attachment 110658 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10032648
Comment 5 Kent Tamura 2011-10-12 03:56:34 PDT
Created attachment 110660 [details]
Patch 3

Fix Chromium build again
Comment 6 Darin Adler 2011-10-12 09:44:05 PDT
Comment on attachment 110660 [details]
Patch 3

If you’re going to change the type, please change it to HTMLFormControlElement, not just HTMLElement. Unless maybe there was a reason you couldn’t do that?
Comment 7 Darin Adler 2011-10-12 09:45:22 PDT
Comment on attachment 110660 [details]
Patch 3

I think the class is using the listItems() function too much internally with lots of local variables that have a reference to the list; this is leftover from where the list was in a separate object. I’d prefer a design where, inside the class, we call an explicit updateListItems function and then use m_listItems directly.
Comment 8 Gustavo Noronha (kov) 2011-10-12 14:41:46 PDT
Comment on attachment 110660 [details]
Patch 3

Attachment 110660 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10044039
Comment 9 Kent Tamura 2011-10-13 00:42:58 PDT
(In reply to comment #6)
> (From update of attachment 110660 [details])
> If you’re going to change the type, please change it to HTMLFormControlElement, not just HTMLElement. Unless maybe there was a reason you couldn’t do that?

m_listItems contains <hr> elements. This behavior was introduced by http://trac.webkit.org/changeset/10433.  I don't know this behavior is needed now.
Comment 10 Kent Tamura 2011-10-13 00:58:45 PDT
Created attachment 110809 [details]
Patch for landing

Fix GTK build.
Comment 11 WebKit Review Bot 2011-10-13 02:07:27 PDT
Comment on attachment 110809 [details]
Patch for landing

Clearing flags on attachment: 110809

Committed r97354: <http://trac.webkit.org/changeset/97354>
Comment 12 WebKit Review Bot 2011-10-13 02:07:33 PDT
All reviewed patches have been landed.  Closing bug.