Bug 69812 – Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement

[Kent Tamura]

Created attachment 110459 [details]
Patch

[WebKit Review Bot]

Comment on attachment 110459 [details]
Patch

Attachment 110459 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10030195

[Early Warning System Bot]

Comment on attachment 110459 [details]
Patch

Attachment 110459 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10028167

[Gyuyoung Kim]

Comment on attachment 110459 [details]
Patch

Attachment 110459 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10028169

[Kent Tamura]

Created attachment 110462 [details]
Patch 2

Fix Release build

[Ryosuke Niwa]

Comment on attachment 110462 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=110462&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:645
> +void HTMLSelectElement::checkListItems() const
> +{

It's unfortunate that we'll end up calling this function even in release builds :(

[Kent Tamura]

Committed r97121: <http://trac.webkit.org/changeset/97121>

[Kent Tamura]

(In reply to comment #7)
> Committed r97121: <http://trac.webkit.org/changeset/97121>

Landed with an HTMLSelectElementWin.cpp build fix.

[Kent Tamura]

http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r97121%20(24480)/results.html

I rolled r97121 out because of regressions.  I should have waited until cr-linux EWS...

[Kent Tamura]

Comment on attachment 110462 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=110462&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:656
> +        const_cast<HTMLSelectElement*>(this)->recalcListItemsInternal(false);

The function argument should not be 'false.'
The original code didn't have the bool argument, and the default value is 'true.'

[Kent Tamura]

Created attachment 110478 [details]
Patch for landing

Fix listItems() error.

[WebKit Review Bot]

Comment on attachment 110478 [details]
Patch for landing

Clearing flags on attachment: 110478

Committed r97135: <http://trac.webkit.org/changeset/97135>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 110462 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=110462&action=review

>> Source/WebCore/html/HTMLSelectElement.cpp:645
>> +{
> 
> It's unfortunate that we'll end up calling this function even in release builds :(

The simple way to avoid that is to put an empty inline version of this in the header. Or to make sure this is called only in this file and mark it inline in here.