Bug 66430

Summary:

[chromium] Remove LayerRendererChromium references from the LayerChromium tree

Product:

WebKit

Reporter:

Adrienne Walker <enne>

Component:

WebCore Misc.

Assignee:

Adrienne Walker <enne>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enne, husky, jamesr, nduca

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

66065, 66432, 66433, 66434, 66435, 66439, 66807

Bug Blocks:

67438

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	jamesr: review+

Adrienne Walker

Reported 2011-08-17 16:46:02 PDT

LayerRendererChromium is a compositor thread-side class that currently both LayerChromium- and CCLayerImpl-derived classes access, mostly to get at the context and settings. LayerChromium::layerRenderer() and LayerChromium::layerRendererContext() should both be removed, once alternate functionality is put in place for all of the LayerChromium-derived classes.

Attachments
Patch (26.46 KB, patch) 2011-09-01 12:46 PDT, Adrienne Walker	no flags	Details Formatted Diff Diff
Patch (26.45 KB, patch) 2011-09-01 12:51 PDT, Adrienne Walker	no flags	Details Formatted Diff Diff
Patch (26.47 KB, patch) 2011-09-01 16:26 PDT, Adrienne Walker	jamesr: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adrienne Walker

Comment 1 2011-09-01 12:46:27 PDT

Created attachment 106011 [details] Patch

Adrienne Walker

Comment 2 2011-09-01 12:48:26 PDT

This needs bug 66807 to land before this patch will apply, so leaving the review flag off. nduca: I'd love if you could sanity check what I did in WebGLLayerChromium to punch through the compositor context in the single-threaded case. I used a bunch of functions that looked like they were temporary and would eventually go away. If you have a better idea about how to do this, I'll take suggestions. :)

Adrienne Walker

Comment 3 2011-09-01 12:51:02 PDT

Created attachment 106013 [details] Patch

Nat Duca

Comment 4 2011-09-01 15:57:56 PDT

Comment on attachment 106013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106013&action=review Me <3's this patch. > Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:152 > + return 0; ASSERT(false); CRASH()

Adrienne Walker

Comment 5 2011-09-01 16:26:15 PDT

Created attachment 106059 [details] Patch

James Robinson

Comment 6 2011-09-01 17:00:36 PDT

Comment on attachment 106059 [details] Patch R=me

Nat Duca

Comment 7 2011-09-02 00:19:09 PDT

Comment on attachment 106059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106059&action=review > Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:149 > +#if USE(THREADED_COMPOSITING) Sorry for the late breaking feedback, but can we do this as a runtime check? E.g. layerTreeHost()->settings().useThreadedCompositing

Adrienne Walker

Comment 8 2011-09-02 09:10:10 PDT

(In reply to comment #7) > (From update of attachment 106059 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106059&action=review > > > Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:149 > > +#if USE(THREADED_COMPOSITING) > > Sorry for the late breaking feedback, but can we do this as a runtime check? E.g. layerTreeHost()->settings().useThreadedCompositing Ah, you're totally right. I'll fix that when landing.

Adrienne Walker

Comment 9 2011-09-02 10:35:10 PDT

Committed r94431: <http://trac.webkit.org/changeset/94431>

Note You need to log in before you can comment on or make changes to this bug.