Bug 63793

Summary:

new-run-webkit-tests output gets confused when logging

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, dpranke, eric, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

64491

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	abarth: review+

Description Adam Barth 2011-07-01 01:10:56 PDT

new-run-webkit-tests output gets confused when logging

Comment 1 Adam Barth 2011-07-01 01:13:09 PDT

Created attachment 99443 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-07-01 01:17:31 PDT

Comment on attachment 99443 [details]
Patch

OK.  How do we test this?

Comment 3 Adam Barth 2011-07-01 01:31:00 PDT

> OK.  How do we test this?

Dunno.  It actually fails in a different way.  :(

Comment 4 Dirk Pranke 2011-07-01 15:59:59 PDT

There are actually unit tests for this module (metered_stream_unittest.py). You can at least update them with what the expected behavior would be.

I'm not surprised if it is failing in a different way, because I remember having to play with the ordering once or twice to get it to even mostly work.

One solution would be to route all logging from the workers to the master so that it could coordinate the cursor state. I looked into doing that once (when we were getting duplicate messages in the log from the workers) but only got about halfway through before I realized the problem was actually that there were two loggers running in that case.

Another (presumably much less portable) option would be to push the MeteredStream's state into some form of shared memory.

Comment 5 Adam Barth 2011-07-01 16:30:24 PDT

Comment on attachment 99443 [details]
Patch

Logging in NRWT is way too complicated.  I'd prefer to just do something simpler.

Comment 6 Dirk Pranke 2012-06-08 18:59:18 PDT

*** Bug 67164 has been marked as a duplicate of this bug. ***

Comment 7 Dirk Pranke 2012-06-14 22:31:48 PDT

Created attachment 147733 [details]
Patch

Comment 8 Dirk Pranke 2012-06-15 14:48:51 PDT

Created attachment 147902 [details]
Patch

Comment 9 Adam Barth 2012-06-18 11:52:21 PDT

Comment on attachment 147902 [details]
Patch

I don't really understand python logging enough to really understanding this patch.  Are you looking for a real review or just a rubber stamp?

Comment 10 Adam Barth 2012-06-18 12:10:43 PDT

Comment on attachment 147902 [details]
Patch

dpranke told me in #webkit that he's just look for an rs here, which I'm happy to provide.

Comment 11 Dirk Pranke 2012-06-18 13:00:07 PDT

Committed r120619: <http://trac.webkit.org/changeset/120619>