Bug 61644

Summary: [Qt][WK2] Clean up skipped list
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 61785    
Bug Blocks:    
Attachments:
Description Flags
patch
none
Updated patch none

Balazs Kelemen
Reported 2011-05-27 09:20:03 PDT
Finally I believe we should remove the tests that are skipped via the mac-wk2 list. The grouping in this file is also broken.
Attachments
patch (105.69 KB, patch)
2011-05-27 09:27 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Updated patch (81.99 KB, patch)
2011-07-01 05:23 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2011-05-27 09:27:54 PDT
Created attachment 95183 [details] patch
Csaba Osztrogonác
Comment 2 2011-05-27 10:02:55 PDT
I'm going to review it on monday.
Csaba Osztrogonác
Comment 3 2011-05-31 07:39:25 PDT
The idea is good, but we should wait for bug 61785.
Csaba Osztrogonác
Comment 4 2011-05-31 07:43:01 PDT
Comment on attachment 95183 [details] patch r-, because we don't need platform/qt-wk2/Skipped.old, we can easily find the previous version from the SVN repository. Could you update this patch after bug 61785 is fixed, please?
Balazs Kelemen
Comment 5 2011-05-31 07:53:41 PDT
(In reply to comment #4) > (From update of attachment 95183 [details]) > r-, because we don't need platform/qt-wk2/Skipped.old, we > can easily find the previous version from the SVN repository. > > Could you update this patch after bug 61785 is fixed, please? Sure.
Balazs Kelemen
Comment 6 2011-07-01 05:23:16 PDT
Created attachment 99461 [details] Updated patch
Andreas Kling
Comment 7 2011-07-01 08:46:12 PDT
Comment on attachment 99461 [details] Updated patch rs=me
WebKit Review Bot
Comment 8 2011-07-01 09:56:59 PDT
Comment on attachment 99461 [details] Updated patch Clearing flags on attachment: 99461 Committed r90242: <http://trac.webkit.org/changeset/90242>
WebKit Review Bot
Comment 9 2011-07-01 09:57:04 PDT
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 10 2012-05-07 15:22:30 PDT
Sorry for the noise, I just want to try how to refer to another bug. So, 83024 ? #83024 ?
Csaba Osztrogonác
Comment 11 2012-05-08 01:48:53 PDT
(In reply to comment #10) > Sorry for the noise, I just want to try how to refer to another bug. > So, 83024 ? #83024 ? or bug83024 ?
Balazs Kelemen
Comment 12 2012-05-08 01:49:40 PDT
(In reply to comment #11) > (In reply to comment #10) > > Sorry for the noise, I just want to try how to refer to another bug. > > So, 83024 ? #83024 ? > > or bug83024 ? That's it, thanks! :D
Note You need to log in before you can comment on or make changes to this bug.