Bug 61644 - [Qt][WK2] Clean up skipped list
: [Qt][WK2] Clean up skipped list
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All All
: P3 Normal
Assigned To:
:
: Qt
: 61785
:
  Show dependency treegraph
 
Reported: 2011-05-27 09:20 PST by
Modified: 2012-05-08 01:49 PST (History)


Attachments
patch (105.69 KB, patch)
2011-05-27 09:27 PST, Balazs Kelemen
no flags Review Patch | Details | Formatted Diff | Diff
Updated patch (81.99 KB, patch)
2011-07-01 05:23 PST, Balazs Kelemen
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-27 09:20:03 PST
Finally I believe we should remove the tests that are skipped via the mac-wk2 list.
The grouping in this file is also broken.
------- Comment #1 From 2011-05-27 09:27:54 PST -------
Created an attachment (id=95183) [details]
patch
------- Comment #2 From 2011-05-27 10:02:55 PST -------
I'm going to review it on monday.
------- Comment #3 From 2011-05-31 07:39:25 PST -------
The idea is good, but we should wait for bug 61785.
------- Comment #4 From 2011-05-31 07:43:01 PST -------
(From update of attachment 95183 [details])
r-, because we don't need platform/qt-wk2/Skipped.old, we 
can easily find the previous version from the SVN repository.

Could you update this patch after bug 61785 is fixed, please?
------- Comment #5 From 2011-05-31 07:53:41 PST -------
(In reply to comment #4)
> (From update of attachment 95183 [details] [details])
> r-, because we don't need platform/qt-wk2/Skipped.old, we 
> can easily find the previous version from the SVN repository.
> 
> Could you update this patch after bug 61785 is fixed, please?

Sure.
------- Comment #6 From 2011-07-01 05:23:16 PST -------
Created an attachment (id=99461) [details]
Updated patch
------- Comment #7 From 2011-07-01 08:46:12 PST -------
(From update of attachment 99461 [details])
rs=me
------- Comment #8 From 2011-07-01 09:56:59 PST -------
(From update of attachment 99461 [details])
Clearing flags on attachment: 99461

Committed r90242: <http://trac.webkit.org/changeset/90242>
------- Comment #9 From 2011-07-01 09:57:04 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #10 From 2012-05-07 15:22:30 PST -------
Sorry for the noise, I just want to try how to refer to another bug.
So, 83024 ? #83024 ?
------- Comment #11 From 2012-05-08 01:48:53 PST -------
(In reply to comment #10)
> Sorry for the noise, I just want to try how to refer to another bug.
> So, 83024 ? #83024 ?

or bug83024 ?
------- Comment #12 From 2012-05-08 01:49:40 PST -------
(In reply to comment #11)
> (In reply to comment #10)
> > Sorry for the noise, I just want to try how to refer to another bug.
> > So, 83024 ? #83024 ?
> 
> or bug83024 ?

That's it, thanks! :D