Bug 83024 – [Qt][WK2] TestNetscapePlugin is broken

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Balazs Kelemen]

Oops... Works locally. Weird. Need to look into.

[Balazs Kelemen]

In fact, we do not even build the test plugin so it's not a surprise that tests don't work.

[Balazs Kelemen]

Created attachment 135586 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 135586 [details]
Patch

LGTM, r=me.

[Balazs Kelemen]

Comment on attachment 135586 [details]
Patch

Landed in http://trac.webkit.org/changeset/113703

[Csaba Osztrogonác]

Reopen, because it made 3 tests crash on Qt5-WK2:

Regressions: Unexpected crashes : (3)
  compositing/repaint/become-overlay-composited-layer.html = CRASH
  fast/frames/iframe-remove-after-id-change.html = CRASH
  plugins/change-widget-and-click-crash.html = CRASH

Unfortunately these tests work on themselves, but fail if you run all tests.

Have you got any idea what happened?

[Csaba Osztrogonác]

Any progression with fixing the crashes?

[Csaba Osztrogonác]

Any progression with fixing? Unfortunately the WK2 bot is still red because of this bug.

[Csaba Osztrogonác]

Any progression with fixing this regression? Or do you think if crashes are OK in the trunk WebKit2?

[Balazs Kelemen]

(In reply to comment #8)
> Any progression with fixing this regression? Or do you think if crashes are OK in the trunk WebKit2?

I tried but I could not reproduce the regression reliably. When I runned tests in  Ubuntu I saw 3 crashes. Not always the same ones. (This is the case on the bot as well.) The strange thing is that: with ulimit -c unlimited + echo core.%p > /proc/sys/kernel/core_pattern I only got one core dump for the whole test session. Seems like the other two crashes detected by nrwt are not real crashes. Furthermore, the core dump I got is unrelated to plugins or plugin process, it's about rendering. After all, I am a bit puzzled about how should I reproduce / fix the problem. Anyway, this is way off topic for this bug. I'm going to file a new.

[Csaba Osztrogonác]

No, it isn't offtopic. Because your patch caused these crashes.

[Balazs Kelemen]

Filed https://bugs.webkit.org/show_bug.cgi?id=84436

[Balazs Kelemen]

Repone, since the patch had been rolled out.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.