Bug 83024 - [Qt][WK2] TestNetscapePlugin is broken
Summary: [Qt][WK2] TestNetscapePlugin is broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
Keywords: LayoutTestFailure, Qt, QtTriaged
Depends on: 84436
Blocks: 79668
  Show dependency treegraph
Reported: 2012-04-03 06:11 PDT by Balazs Kelemen
Modified: 2014-02-03 03:20 PST (History)
3 users (show)

See Also:

Patch (5.04 KB, patch)
2012-04-04 07:24 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-04-03 06:11:41 PDT
Oops... Works locally. Weird. Need to look into.
Comment 1 Balazs Kelemen 2012-04-04 05:54:00 PDT
In fact, we do not even build the test plugin so it's not a surprise that tests don't work.
Comment 2 Balazs Kelemen 2012-04-04 07:24:39 PDT
Created attachment 135586 [details]
Comment 3 Csaba Osztrogonác 2012-04-10 02:14:46 PDT
Comment on attachment 135586 [details]

LGTM, r=me.
Comment 4 Balazs Kelemen 2012-04-10 09:21:16 PDT
Comment on attachment 135586 [details]

Landed in http://trac.webkit.org/changeset/113703
Comment 5 Csaba Osztrogonác 2012-04-11 08:46:30 PDT
Reopen, because it made 3 tests crash on Qt5-WK2:

Regressions: Unexpected crashes : (3)
  compositing/repaint/become-overlay-composited-layer.html = CRASH
  fast/frames/iframe-remove-after-id-change.html = CRASH
  plugins/change-widget-and-click-crash.html = CRASH

Unfortunately these tests work on themselves, but fail if you run all tests.

Have you got any idea what happened?
Comment 6 Csaba Osztrogonác 2012-04-12 06:49:20 PDT
Any progression with fixing the crashes?
Comment 7 Csaba Osztrogonác 2012-04-16 04:01:51 PDT
Any progression with fixing? Unfortunately the WK2 bot is still red because of this bug.
Comment 8 Csaba Osztrogonác 2012-04-20 01:05:18 PDT
Any progression with fixing this regression? Or do you think if crashes are OK in the trunk WebKit2?
Comment 9 Balazs Kelemen 2012-04-20 04:44:01 PDT
(In reply to comment #8)
> Any progression with fixing this regression? Or do you think if crashes are OK in the trunk WebKit2?

I tried but I could not reproduce the regression reliably. When I runned tests in  Ubuntu I saw 3 crashes. Not always the same ones. (This is the case on the bot as well.) The strange thing is that: with ulimit -c unlimited + echo core.%p > /proc/sys/kernel/core_pattern I only got one core dump for the whole test session. Seems like the other two crashes detected by nrwt are not real crashes. Furthermore, the core dump I got is unrelated to plugins or plugin process, it's about rendering. After all, I am a bit puzzled about how should I reproduce / fix the problem. Anyway, this is way off topic for this bug. I'm going to file a new.
Comment 10 Csaba Osztrogonác 2012-04-20 04:51:48 PDT
No, it isn't offtopic. Because your patch caused these crashes.
Comment 11 Balazs Kelemen 2012-04-20 04:55:50 PDT
Filed https://bugs.webkit.org/show_bug.cgi?id=84436
Comment 12 Balazs Kelemen 2012-05-07 15:15:08 PDT
Repone, since the patch had been rolled out.
Comment 13 Jocelyn Turcotte 2014-02-03 03:20:31 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.