Bug 61785 - [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
: [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 61644 63780
  Show dependency treegraph
 
Reported: 2011-05-31 07:30 PST by
Modified: 2011-06-30 20:07 PST (History)


Attachments
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (100.00 KB, patch)
2011-06-28 04:40 PST, Fehér Zsolt
ossy: review-
ossy: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (98.50 KB, patch)
2011-06-28 04:41 PST, Fehér Zsolt
ossy: review-
ossy: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (100.90 KB, patch)
2011-06-29 03:39 PST, Fehér Zsolt
no flags Review Patch | Details | Formatted Diff | Diff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (102.06 KB, patch)
2011-06-29 03:47 PST, Fehér Zsolt
no flags Review Patch | Details | Formatted Diff | Diff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (202.88 KB, patch)
2011-06-29 04:35 PST, Fehér Zsolt
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-31 07:30:13 PST
Now we have mac-wk2, win-wk2 and qt-wk2 WebKit2 platforms.

mac-wk2/Skipped list are used for win-wk2 and qt-wk2 platforms too. It 
is confusing a little bit for developers, so it would be better if we use 
a general wk2/Skipped list instead of mac-wk2/Skipped to disable tests which 
need layoutTestController, eventSender implementation or tests fail because 
of general WebKit2 bugs. 

What do you think about it?
------- Comment #1 From 2011-05-31 07:35:34 PST -------
Sounds reasonable.
------- Comment #2 From 2011-06-28 04:40:08 PST -------
Created an attachment (id=98898) [details]
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
------- Comment #3 From 2011-06-28 04:41:01 PST -------
Created an attachment (id=98899) [details]
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
------- Comment #4 From 2011-06-28 05:02:35 PST -------
(From update of attachment 98898 [details])
r-, because we need only one patch. And I don't think if changes in Tools/Scripts/old-run-webkit-tests 
will be enough. There are many other occurances of mac-wk in ORWT script. Kristóf, you experimented with it,
what do you think about it?
------- Comment #5 From 2011-06-28 05:04:03 PST -------
And please use git diff -M to detect file renaming.
------- Comment #6 From 2011-06-28 05:48:36 PST -------
(In reply to comment #4)
> (From update of attachment 98898 [details] [details])
> r-, because we need only one patch. And I don't think if changes in Tools/Scripts/old-run-webkit-tests 
> will be enough. There are many other occurances of mac-wk in ORWT script. Kristóf, you experimented with it,
> what do you think about it?

The $platform variable will still contain "mac-wk2" so there is no need to patch every place where is it used. We can assure that the patch is correct by comparing the set of tests that we run with and without it - those should be identical.
------- Comment #7 From 2011-06-29 03:39:51 PST -------
Created an attachment (id=99066) [details]
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
------- Comment #8 From 2011-06-29 03:47:34 PST -------
Created an attachment (id=99067) [details]
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
------- Comment #9 From 2011-06-29 04:35:55 PST -------
Created an attachment (id=99071) [details]
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
------- Comment #10 From 2011-06-30 09:28:01 PST -------
(From update of attachment 99071 [details])
LGTM, r=me.
------- Comment #11 From 2011-06-30 09:29:34 PST -------
(From update of attachment 99071 [details])
Landed in http://trac.webkit.org/changeset/90125
------- Comment #12 From 2011-06-30 20:07:00 PST -------
Fixed NRWT in bug 63780.