Bug 57779
| Summary: | [meta] refactoring of RenderBlockLineLayout.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Enhancement | CC: | eric, hyatt, jamesr, joepeck, leviw, mitz, yael |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 58557, 36921, 57851, 57947, 57965, 58028, 58362, 58400, 58411, 60044, 60046, 60072, 60082, 60117, 60209 | ||
| Bug Blocks: | |||
Ryosuke Niwa
findNextLineBreak is an ancient function and violates almost all WebKit style guides. We should cleanup this function and split it into smaller pieces.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Levi Weintraub
Changing the name because there's lots of good refactoring to be done in that entire file.
Eric Seidel (no email)
I want to split most of the code in this file off into a new class called LineBoxTree. Basically RenderBlock should be *much* simpler than it is today, and all of the line-box-tree related code should move into a new LineBoxTree class which it has one of as a m_lineboxTree member.