Summary: | Implement CSSPropertyDirection in CSSStyleApplyProperty | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, macpherson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 46592 | ||||||
Attachments: |
|
Description
Luke Macpherson
2011-03-31 22:33:42 PDT
Created attachment 87826 [details]
Patch
Comment on attachment 87826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87826&action=review Otherwise looks OK. > Source/WebCore/css/CSSStyleApplyProperty.cpp:145 > + ApplyPropertyDirection(TextDirection (RenderStyle::*getter)() const, void (RenderStyle::*setter)(TextDirection), TextDirection (*initial)()) > + : ApplyPropertyDefault<TextDirection>(getter, setter, initial) > + { > + } This isn't needed, or? From IRC: mikelawther: yeah - you can only automatically call a default constructor mikelawther: ie one with no args mikelawther: or one where all the args have default values mikelawther: which is not the case here - so you have to call it explicitly Comment on attachment 87826 [details]
Patch
ok.
The commit-queue encountered the following flaky tests while processing attachment 87826 [details]: http/tests/security/xssAuditor/post-from-iframe.html bug 57852 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 87826 [details] Patch Clearing flags on attachment: 87826 Committed r82942: <http://trac.webkit.org/changeset/82942> All reviewed patches have been landed. Closing bug. |