Bug 57608 - Implement CSSPropertyDirection in CSSStyleApplyProperty
Summary: Implement CSSPropertyDirection in CSSStyleApplyProperty
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 46592
  Show dependency treegraph
Reported: 2011-03-31 22:33 PDT by Luke Macpherson
Modified: 2011-04-05 08:36 PDT (History)
3 users (show)

See Also:

Patch (4.77 KB, patch)
2011-03-31 22:39 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-03-31 22:33:42 PDT
Implement CSSPropertyDirection in CSSStyleApplyProperty
Comment 1 Luke Macpherson 2011-03-31 22:39:05 PDT
Created attachment 87826 [details]
Comment 2 Eric Seidel (no email) 2011-04-03 21:37:47 PDT
Comment on attachment 87826 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=87826&action=review

Otherwise looks OK.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:145
> +    ApplyPropertyDirection(TextDirection (RenderStyle::*getter)() const, void (RenderStyle::*setter)(TextDirection), TextDirection (*initial)())
> +        : ApplyPropertyDefault<TextDirection>(getter, setter, initial)
> +    {
> +    }

This isn't needed, or?
Comment 3 Luke Macpherson 2011-04-03 22:38:41 PDT
From IRC:
mikelawther: yeah - you can only automatically call a default constructor
mikelawther: ie one with no args
mikelawther: or one where all the args have default values
mikelawther: which is not the case here - so you have to call it explicitly
Comment 4 Dimitri Glazkov (Google) 2011-04-05 07:48:47 PDT
Comment on attachment 87826 [details]

Comment 5 WebKit Commit Bot 2011-04-05 08:33:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 87826 [details]:

http/tests/security/xssAuditor/post-from-iframe.html bug 57852 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-04-05 08:36:35 PDT
Comment on attachment 87826 [details]

Clearing flags on attachment: 87826

Committed r82942: <http://trac.webkit.org/changeset/82942>
Comment 7 WebKit Commit Bot 2011-04-05 08:36:39 PDT
All reviewed patches have been landed.  Closing bug.