Summary: | JObjectWrapper should be moved to its own file | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, jorlow, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 55387 | ||||||
Bug Blocks: | 55383, 55763 | ||||||
Attachments: |
|
Description
Steve Block
2011-02-28 08:55:16 PST
Created attachment 84305 [details]
Patch
Comment on attachment 84305 [details]
Patch
Is Jobject (vs JObject) actually correct?
r=me
Comment on attachment 84305 [details] Patch Rejecting attachment 84305 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build'..." exit_code: 2 Last 500 characters of output: ork/Resources/pbxcp -exclude .DS_Store -exclude CVS -exclude .svn -strip-debug-symbols -resolve-src-symlinks /mnt/git/webkit-commit-queue/WebKitBuild/Release/WebProcess.app /mnt/git/webkit-commit-queue/WebKitBuild/Release/WebKit2.framework ** BUILD FAILED ** The following build commands failed: WebKit2: PhaseScriptExecution "Check For Inappropriate Files In Framework" /mnt/git/webkit-commit-queue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Script-5DF408D1131DDBEC00130071.sh (1 failure) Full output: http://queues.webkit.org/results/8074778 Comment on attachment 84305 [details]
Patch
WebKit2 build break unrelated to this change, trying again.
Odd. I'm not sure how that could happen. Comment on attachment 84305 [details] Patch Clearing flags on attachment: 84305 Committed r80103: <http://trac.webkit.org/changeset/80103> All reviewed patches have been landed. Closing bug. |