Summary: | JNI code should include <jni.h> on non-OSX platforms. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||||||||
Component: | New Bugs | Assignee: | Steve Block <steveblock> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, commit-queue, darin, eric, jorlow, steveblock, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 55383, 55387 | ||||||||||||
Attachments: |
|
Description
Steve Block
2011-02-25 07:52:27 PST
JavaVM/jni.h seems to be a valid path on Mac, but not on other platforms. Created attachment 83815 [details]
Patch
Is <jni.h> a valid path on Mac? Attachment 83815 [details] did not build on mac: Build output: http://queues.webkit.org/results/8031380 Comment on attachment 83815 [details]
Patch
r- since this breaks Mac build.
Created attachment 84038 [details]
Patch
Comment on attachment 84038 [details]
Patch
Not yet ready for review, just checking that Mac build is OK.
Attachment 84038 [details] did not build on mac: Build output: http://queues.webkit.org/results/8076245 It seems that setting the include path manually for jni.h causes problems on OSX, as this is a frameworks header and needs some defines to be set up. Instead I think it's best to use a conditional include based on the OS. Created attachment 84054 [details]
Patch
Created attachment 84072 [details]
Patch
Comment on attachment 84072 [details]
Patch
r=me
The commit-queue encountered the following flaky tests while processing attachment 84072 [details]: media/invalid-media-url-crash.html bug 51138 (authors: inferno@chromium.org and jamesr@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 84072 [details] Patch Clearing flags on attachment: 84072 Committed r79947: <http://trac.webkit.org/changeset/79947> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/79947 might have broken Qt Linux Release The following tests are not passing: fast/events/tabindex-focus-blur-all.html fast/frames/iframe-plugin-load-remove-document-crash.html fast/frames/sandboxed-iframe-attribute-parsing.html fast/layers/clip-rects-transformed.html fast/replaced/object-with-non-empty-classid-triggers-fallback.html plugins/createScriptableObject-before-start.html plugins/destroy-on-setwindow.html plugins/destroy-plugin-from-callback.html plugins/destroy-stream-twice.html plugins/document-open.html plugins/evaluate-js-after-removing-plugin-element.html plugins/get-file-url.html plugins/get-url-that-the-resource-load-delegate-will-disallow.html plugins/get-url-with-javascript-destroying-plugin.html plugins/geturl-replace-query.html plugins/geturlnotify-during-document-teardown.html plugins/instance-available-before-stylesheets-loaded-object.html plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html plugins/js-from-destroy.html |