Bug 49127
| Summary: | [Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | benjamin, cmarcelo, hyatt, joel.parks, kadam, laszlo.gombos, luiz, ossy, robert |
| Priority: | P2 | Keywords: | Qt, QtTriaged, Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 47237, 79666 | ||
Csaba Osztrogonác
r71465 make editing/selection/after-line-break.html fail on Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r71467%20%2823280%29/editing/selection/after-line-break-pretty-diff.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
Skipped until fix: http://trac.webkit.org/changeset/71504
Robert Hogan
It looks like only Mac platforms get the new expected result for this test.
Chromium Win and Linux both get what Qt does:
https://bugs.webkit.org/show_bug.cgi?id=47237#c10
Gtk skips this test already.
I think our results are good.
Luiz Agostini
As Robert said our results seems to be OK and the bug that should be blocked by this one is now RESOLVED FIXED.
I think that we should keep this bug open as a reminder but we should change its priority. I will do it if no one has objections.
Joel Parks
(In reply to comment #3)
> As Robert said our results seems to be OK and the bug that should be blocked by this one is now RESOLVED FIXED.
>
> I think that we should keep this bug open as a reminder but we should change its priority. I will do it if no one has objections.
please do
Csaba Osztrogonác
It still fails, here is the diff:
--- /home/oszi/WebKit/WebKitBuild/Release/layout-test-results/editing/selection/after-line-break-expected.txt
+++ /home/oszi/WebKit/WebKitBuild/Release/layout-test-results/editing/selection/after-line-break-actual.txt
@@ -1,6 +1,6 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
Test for rdar://problem/5973313 REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas.
Ádám Kallai
Is Anybody working this bug? This test still fails on Qt. The fail is same.
Csaba Osztrogonác
still valid bug
Ádám Kallai
The bug is still vaild.