Bug 45235

Summary: [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gustavo, ojan, tonikitoo, webkit.review.bot, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 45233    
Bug Blocks: 38656    
Attachments:
Description Flags
Add modifier support to mouseDown and mouseUp none

Martin Robinson
Reported 2010-09-04 15:46:03 PDT
The EventSender currently ignores modifier key arguments to these methods.
Attachments
Add modifier support to mouseDown and mouseUp (7.04 KB, patch)
2010-09-04 15:51 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-09-04 15:51:17 PDT
Created attachment 66592 [details] Add modifier support to mouseDown and mouseUp
Xan Lopez
Comment 2 2010-09-04 23:42:13 PDT
Comment on attachment 66592 [details] Add modifier support to mouseDown and mouseUp You sir are a gentleman and a scholar.
Martin Robinson
Comment 3 2010-09-06 07:44:50 PDT
Comment on attachment 66592 [details] Add modifier support to mouseDown and mouseUp Clearing flags on attachment: 66592 Committed r66829: <http://trac.webkit.org/changeset/66829>
Martin Robinson
Comment 4 2010-09-06 07:44:55 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-09-06 08:17:24 PDT
http://trac.webkit.org/changeset/66829 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/66827 http://trac.webkit.org/changeset/66828 http://trac.webkit.org/changeset/66829
Note You need to log in before you can comment on or make changes to this bug.