Bug 42508

Summary: [Qt] Render shadow when drawing one canvas onto another
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: qi.2.zhang
Priority: P2 Keywords: HTML5, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 42510    
Description Flags
Proposed patch none

Description Andreas Kling 2010-07-17 17:35:10 PDT
This test currently fails for Qt:
- canvas/philip/tests/2d.shadow.canvas.basic.html
Comment 1 Andreas Kling 2010-07-17 17:37:19 PDT
Created attachment 61891 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-07-19 07:16:57 PDT
Comment on attachment 61891 [details]
Proposed patch

LGTM. Any change in performance?
Comment 3 Andreas Kling 2010-07-19 07:21:27 PDT
(In reply to comment #2)
> (From update of attachment 61891 [details])
> LGTM. Any change in performance?

If painting with a shadow, there is obviously a slight performance penalty. But no more painful than drawing something else with a shadow.
Comment 4 Andreas Kling 2010-07-19 07:24:44 PDT
Comment on attachment 61891 [details]
Proposed patch

Clearing flags on attachment: 61891

Committed r63656: <http://trac.webkit.org/changeset/63656>
Comment 5 Andreas Kling 2010-07-19 07:24:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 qi 2010-07-19 12:43:13 PDT
*** Bug 42582 has been marked as a duplicate of this bug. ***