Bug 41680

Summary:

[Qt] QtScript should provide an API for enumerating a JS object's properties

Product:

WebKit

Reporter:

Kent Hansen <kent.hansen>

Component:

JavaScriptCore

Assignee:

Jędrzej Nowacki <jedrzej.nowacki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, jedrzej.nowacki, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

41769

Bug Blocks:

31863

Attachments:

Description	Flags
Fix v1	none
Fix v1.01	none

Kent Hansen

Reported 2010-07-06 03:18:22 PDT

See http://doc.trolltech.com/latest/qscriptvalueiterator.html

Attachments
Fix v1 (39.32 KB, patch) 2010-07-09 03:27 PDT, Jędrzej Nowacki	no flags	Details Formatted Diff Diff
Fix v1.01 (39.32 KB, patch) 2010-07-13 08:15 PDT, Jędrzej Nowacki	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jędrzej Nowacki

Comment 1 2010-07-09 03:27:44 PDT

Created attachment 61029 [details] Fix v1

WebKit Review Bot

Comment 2 2010-07-09 03:35:23 PDT

Attachment 61029 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/QtScript.pro" JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:23: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:24: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.h" WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator_p.h" WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.cpp" Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jędrzej Nowacki

Comment 3 2010-07-13 02:37:02 PDT

(In reply to comment #2) > If any of these errors are false positives, please file a bug against check-webkit-style. Bug 35151

Kent Hansen

Comment 4 2010-07-13 03:36:53 PDT

(In reply to comment #1) > Created an attachment (id=61029) [details] > Fix v1 Looks good except for the "to" in "Introduce to QScriptValueIterator". And why the trailing comma in "arguments[] = { *m_object, };"?

Jędrzej Nowacki

Comment 5 2010-07-13 08:15:56 PDT

Created attachment 61378 [details] Fix v1.01

WebKit Review Bot

Comment 6 2010-07-13 08:18:19 PDT

Attachment 61378 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/QtScript.pro" JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:23: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:24: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.h" WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator_p.h" WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.cpp" Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 7 2010-07-13 12:34:13 PDT

Comment on attachment 61378 [details] Fix v1.01 Clearing flags on attachment: 61378 Committed r63233: <http://trac.webkit.org/changeset/63233>

WebKit Commit Bot

Comment 8 2010-07-13 12:34:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.