| Summary: | Remove side effects of form submission and prepare FormDataBuilder for splitting up. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | 40137 | ||||||||
| Bug Blocks: | 40893 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dimitri Glazkov (Google)
2010-06-04 13:15:55 PDT
Created attachment 57909 [details]
Patch
Created attachment 59309 [details]
Patch
Comment on attachment 59309 [details] Patch > + m_formDataBuilder.parseEncodingType("application/x-www-form-urlencoded"); Why is it important to call the parse function instead of the set function here? r=me (In reply to comment #3) > (From update of attachment 59309 [details]) > > + m_formDataBuilder.parseEncodingType("application/x-www-form-urlencoded"); > > Why is it important to call the parse function instead of the set function here? That's actually a good question and points to a problem that I'll figure out how to solve. parseEncodingType sets isMultiPart to false, which is still kind of side-effecty. See assert right next to this statement. > > r=me Committed r61618: <http://trac.webkit.org/changeset/61618> |