Bug 39740

Summary:

[style] Allow usage of NULL in gst_*_many()

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

39472

Attachments:

Description	Flags
proposed patch	levin: review+

Description Philippe Normand 2010-05-26 08:29:30 PDT

The cpp style-checker shouldn't warn about usage of NULL in gst_*_many() calls. It can't be replaced by 0, see also Bug 32858.

Comment 1 Philippe Normand 2010-05-26 08:40:38 PDT

Created attachment 57100 [details]
proposed patch

Comment 2 David Levin 2010-05-26 13:54:45 PDT

Comment on attachment 57100 [details]
proposed patch

I wonder if it should just be gst_*

Care to fix: https://bugs.webkit.org/show_bug.cgi?id=39372 ?
(The problem there was g_build_filename. I wonder if the g_ checks should be broadened to g_*).

Comment 3 Philippe Normand 2010-05-27 00:21:34 PDT

(In reply to comment #2)
> (From update of attachment 57100 [details])
> I wonder if it should just be gst_*
> 

AFAICT it should be enough with gst_*_many. If really needed we can extend this later on, meanwhile I will land this patch :)

> Care to fix: https://bugs.webkit.org/show_bug.cgi?id=39372 ?
> (The problem there was g_build_filename. I wonder if the g_ checks should be broadened to g_*).

Yes it sounds like a good idea, I will tackle the bug above when I get time :)

Comment 4 Philippe Normand 2010-05-27 02:22:59 PDT

Landed in http://trac.webkit.org/changeset/60283
Thanks!