Bug 38412

Summary: Update MIPS JIT for unsigned right shift, Math.sqrt, load16
Product: WebKit Reporter: Chao-ying Fu <fu>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, skyul
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
MIPS JIT Update 20100430
none
MIPS JIT Update 20100507 none

Chao-ying Fu
Reported 2010-04-30 16:13:17 PDT
After recent patches from https://bugs.webkit.org/show_bug.cgi?id=38294 and https://bugs.webkit.org/show_bug.cgi?id=38375, MIPS JIT needs to be updated. I will upload a patch soon. Thanks a lot! Regards, Chao-ying
Attachments
MIPS JIT Update 20100430 (3.99 KB, patch)
2010-04-30 17:21 PDT, Chao-ying Fu 		no flags
DetailsFormatted DiffDiff
MIPS JIT Update 20100507 (4.98 KB, patch)
2010-05-07 17:07 PDT, Chao-ying Fu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chao-ying Fu
Comment 1 2010-04-30 17:21:59 PDT
Created attachment 54839 [details] MIPS JIT Update 20100430 Here is the patch. Thanks! Ex: (test results) 0 regressions found. 0 tests fixed. OK.
Chao-ying Fu
Comment 2 2010-05-07 17:07:47 PDT
Created attachment 55436 [details] MIPS JIT Update 20100507 Fixed MIPS build failures due to recent changes. Thanks! Regards, Chao-ying
Chao-ying Fu
Comment 3 2010-05-11 17:20:45 PDT
From today's testing, I got two regressions. ecma_3/Date/15.9.5.4.js ecma_3/Function/regress-58274.js 2 regressions found. 0 tests fixed. The string access is not correct, if I access from the beginning a[0], a[1], a[2], .... Ex 1: # ./jsc > a="01" 01 > a[0] 0 > a[1] 0 <--- THIS IS WRONG! > a[2] undefined Ex 2: # ./jsc > a="01" 01 > a[2] undefined > a[1] 1 <--- THIS IS CORRECT! > a[0] 0 Can anyone help? Maybe something is wrong in emitSlow_op_get_by_val. Thanks a lot! Regards, Chao-ying
WebKit Commit Bot
Comment 4 2010-05-15 01:59:07 PDT
Comment on attachment 55436 [details] MIPS JIT Update 20100507 Clearing flags on attachment: 55436 Committed r59527: <http://trac.webkit.org/changeset/59527>
WebKit Commit Bot
Comment 5 2010-05-15 01:59:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.