Bug 37663

Summary:

Web Inspector: move JS VM specific code for collecting scope chain data into bindings

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

37740, 37755

Bug Blocks:

Attachments:

Description	Flags
patch	pfeldman: review+

Yury Semikhatsky

Reported 2010-04-15 11:04:07 PDT

Move JS VM specific code for collecting scope chain data into bindings. The scope chain representation is quite different in V8 in JSC and we need to encapsulate this specifics in the bindings layer so that same code in Web Inspector could iterate call frames in both VMs.

Attachments
patch (8.56 KB, patch) 2010-04-23 07:19 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2010-04-23 07:19:43 PDT

Created attachment 54155 [details] patch

Pavel Feldman

Comment 2 2010-04-23 07:56:19 PDT

Comment on attachment 54155 [details] patch Please test this well manually prior to landing.

Yury Semikhatsky

Comment 3 2010-04-23 08:02:18 PDT

Committed r58166

Note You need to log in before you can comment on or make changes to this bug.