Bug 3761 – Code Cleanup: Remove all uncessary #include statements from .h files

• Component: New Bugs
• Status: NEW

[Eric Seidel (no email)]

Code Cleanup:  Remove all uncessary #include statements from .h files

Many, many, many kwq (and khtml) files have uncessary #include statements in the headers, which causes 
massive compile-time dependencies... meaning that a single change in kwq header basically amounts to 
rebuilding all of WebCore (due to the header cascade.

It would be really nice to see this cleaned up.  I will eventually get around to it if noone else does.. but in 
case new WebCore hackers are looking for something easy (and useful), this is such a bug.

[Eric Seidel (no email)]

To be clear:

This means replacing things like:

#include <qstring.h>
with
class QString;
instead.

This is only possible when QString is neither returned from a function in the class, nor used as an 
instance variable on the class itself.

[Arthur Langereis]

Created attachment 3611 [details]
please ignore

This is my proposed patch to add support for optional identifiers to function
expression statements. This is my first ever cvs patch, so please excuse any
mistakes.

[Arthur Langereis]

Comment on attachment 3611 [details]
please ignore

Sorry, sorry, wrong bugreport! Never mind my comments

[Jussi Hagman]

(In reply to comment #0)
> in  case new WebCore hackers are looking for something easy (and useful), this is such a bug.

This sounds like my kind of a job! Are there any issues or tips I should know before I start doing the 
cleanup? Is there any difference where I should start? Should I make one enormous patch or several small 
ones?

[Maciej Stachowiak]

I think doing it incrementally is a good idea. I did some of the work in 4749

[Eric Seidel (no email)]

I tried this again with bug 40350.  We should probably just dup these.

[Akshay Kalbhor]

I know this is an old bug, but it seems beginner-friendly. Is the cleanup still going to help or are all files already clean? Any extra information would be helpful.

[Fujii Hironori]

See also:

Bug 211821 – [IWYU] Try removing redundant includes in WTF implementation files
Bug 211867 – [IWYU] Remove unnecessary includes from JSC implementation files