Bug 3751

Summary: REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content
Product: WebKit Reporter: Daniele Metilli <daniele.metilli>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Critical CC: jorge, matrix9180, Neil, tonyarnold
Priority: P1    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
URL: http://en.wikipedia.org/w/index.php?title=WebKit&action=edit
Attachments:
Description Flags
Test Case
none
Fix bug
mjs: review-
Address comments
andersca: review-
Call updateValue mjs: review+

Daniele Metilli
Reported 2005-06-28 18:06:46 PDT
With the last version of WebKit (June 28), if you try to edit some pages on Wikipedia you obtain a blank form (see the linked URL). The form should contain the current revision of the article instead. Some pages, like http://en.wikipedia.org/w/index.php?title=Current_events&action=edit work correctly. This bug was not present in the last official version of WebKit (412).
Attachments
Test Case (628 bytes, text/html)
2005-07-04 01:11 PDT, Chad Ingram
no flags
Fix bug (3.87 KB, patch)
2005-07-05 03:13 PDT, Anders Carlsson
mjs: review-
Address comments (2.60 KB, patch)
2005-07-08 15:20 PDT, Anders Carlsson
andersca: review-
Call updateValue (2.51 KB, patch)
2005-07-08 16:46 PDT, Anders Carlsson
mjs: review+
Joost de Valk (AlthA)
Comment 1 2005-06-29 01:12:30 PDT
Confirmed, marked p1 and major since it's a major site and thus a major problem :P
Daniele Metilli
Comment 2 2005-06-29 12:06:40 PDT
I've noticed another quite strange thing about this bug. The content of the form appears if you do the following: 1 - Click on the background of the page 2 - Reload the page (If you just reload immediately after loading, or if you click on the form then reload this doesn't work) This could be useful if someone wants to edit Wikipedia pages before the bug is fixed.
Tony Arnold
Comment 3 2005-06-29 14:06:24 PDT
This also seems to be affecting Backpack. Clicking "Edit" on any element results in an empty field.
Joost de Valk (AlthA)
Comment 4 2005-06-30 11:23:35 PDT
*** Bug 3772 has been marked as a duplicate of this bug. ***
Joost de Valk (AlthA)
Comment 5 2005-07-01 05:23:42 PDT
*** Bug 3785 has been marked as a duplicate of this bug. ***
Joost de Valk (AlthA)
Comment 6 2005-07-01 05:25:11 PDT
This one get's reported more, please look into it, as it is breaking some major sites.
Joost de Valk (AlthA)
Comment 7 2005-07-04 01:10:42 PDT
Affects Gmail too, changing summary.
Chad Ingram
Comment 8 2005-07-04 01:11:29 PDT
Created attachment 2782 [details] Test Case
Joost de Valk (AlthA)
Comment 9 2005-07-04 01:54:57 PDT
Affects every Mambo CMS generated site too.
Derek Butterfield
Comment 10 2005-07-04 02:38:38 PDT
Affects Gmail when replying to an e-mail. Address box blank: should be pre-filled with recipient.
Jasenko Blazevic
Comment 11 2005-07-04 20:11:11 PDT
Just pulled the latest code (July 5th) and still not fixed. For people thinking of updating their webkit, stay clear of this unless you are not using Gmail, or other JS text area related sites.
Joost de Valk (AlthA)
Comment 12 2005-07-05 00:11:04 PDT
Testcase crashes Safari when you click on the page. This one get's nicer and nicer :)
Chad Ingram
Comment 13 2005-07-05 02:02:15 PDT
terminal always shows /Users/matrix9180/WebCore/khtml/xml/dom_position.cpp:494: failed assertion `currentPos == start' Abort trap when it crashes
Anders Carlsson
Comment 14 2005-07-05 03:13:09 PDT
Created attachment 2803 [details] Fix bug
mitz
Comment 15 2005-07-05 03:19:03 PDT
(In reply to comment #13) > terminal always shows > /Users/matrix9180/WebCore/khtml/xml/dom_position.cpp:494: failed assertion `currentPos == start' > Abort trap > > when it crashes This assertion failure also shows in bug 3624.
Jasenko Blazevic
Comment 16 2005-07-06 07:31:33 PDT
The attached patch is working in GMail. Cheers guys.
Tony Arnold
Comment 17 2005-07-06 13:13:22 PDT
I can also confirm that the patch works with Gmail, and (thankfully) Backpack too.
Anders Carlsson
Comment 18 2005-07-08 15:20:29 PDT
Created attachment 2870 [details] Address comments
Anders Carlsson
Comment 19 2005-07-08 15:45:11 PDT
Comment on attachment 2870 [details] Address comments This breaks some of the layout tests.
Anders Carlsson
Comment 20 2005-07-08 16:46:29 PDT
Created attachment 2871 [details] Call updateValue We need to call updateValue, otherwise we'll have the same problem when setValue calls updateFromElement
Maciej Stachowiak
Comment 21 2005-07-08 18:08:50 PDT
Comment on attachment 2871 [details] Call updateValue r=me
Neil Lee
Comment 22 2005-07-09 07:42:45 PDT
Don't know if the patch was pulled, but the 0708 and 0709 builds are regressing back to the old, broken behaviour.
Tony Arnold
Comment 23 2005-07-10 17:11:10 PDT
Neil, it was never applied - AFAIK the patch is still in review, and hasn't been merged with ToT. Those of us reporting success have applied the patch manually.
Tony Arnold
Comment 24 2005-07-19 20:54:35 PDT
Why has this been marked as fixed? A build I pulled and compiled 5 minutes ago still has this issue.
Note You need to log in before you can comment on or make changes to this bug.