Bug 37015

Summary:

webkit-patch attached my patch to the wrong bug

Product:

WebKit

Reporter:

Steve Falkenburg <sfalken>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, ericu, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Steve Falkenburg

Reported 2010-04-02 00:23:43 PDT

I filed <https://bugs.webkit.org/show_bug.cgi?id=37014> using webkit-patch. I used: - webkit-prepare - webkit-upload When I uploaded the patch, I edited the changelog a bit (you can see it in the patch). The webkit-patch tool attached the patch to this bug instead: https://bugs.webkit.org/show_bug.cgi?id=36971

Attachments
Patch (14.35 KB, patch) 2010-04-09 00:09 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-04-02 14:30:31 PDT

I'm not sure I know what webkit-prepare or webkit-upload are? Are those internal Apple scripts?

Eric Seidel (no email)

Comment 2 2010-04-02 14:31:13 PDT

I expect he means: webkit-patch prepare webkit-patch upload

Steve Falkenburg

Comment 3 2010-04-02 20:35:01 PDT

Correct. I used: webkit-patch prepare webkit-patch upload No Apple scripts.

Eric Seidel (no email)

Comment 4 2010-04-08 21:56:14 PDT

*** Bug 37107 has been marked as a duplicate of this bug. ***

Eric Seidel (no email)

Comment 5 2010-04-08 21:56:35 PDT

We've had several reports of this recently. We have a theory. Investigating now.

Eric Seidel (no email)

Comment 6 2010-04-08 22:49:02 PDT

I've found a cause of this for SVN users. We have had a report from a Git user which I've not been able to reproduce yet. Fix coming shortly.

Eric Seidel (no email)

Comment 7 2010-04-09 00:09:12 PDT

Created attachment 52940 [details] Patch

Adam Barth

Comment 8 2010-04-09 07:22:28 PDT

Comment on attachment 52940 [details] Patch Yay! Thanks for fixing this bug. + # FIXME: This should probably use cwd=self.checkout_root. We should use checkout_root in all these cases to make SCM more predictable and aligned between SVN and GIT.

Eric Seidel (no email)

Comment 9 2010-04-09 11:31:15 PDT

Comment on attachment 52940 [details] Patch I agree. I'll file a bug about that.

Eric Seidel (no email)

Comment 10 2010-04-09 11:33:23 PDT

Filed bug 37346 for followup.

WebKit Commit Bot

Comment 11 2010-04-09 14:01:45 PDT

Comment on attachment 52940 [details] Patch Clearing flags on attachment: 52940 Committed r57361: <http://trac.webkit.org/changeset/57361>

WebKit Commit Bot

Comment 12 2010-04-09 14:01:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.