Summary: | webkit-patch attached my patch to the wrong bug | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Falkenburg <sfalken> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, ericu, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Steve Falkenburg
2010-04-02 00:23:43 PDT
I'm not sure I know what webkit-prepare or webkit-upload are? Are those internal Apple scripts? I expect he means: webkit-patch prepare webkit-patch upload Correct. I used: webkit-patch prepare webkit-patch upload No Apple scripts. *** Bug 37107 has been marked as a duplicate of this bug. *** We've had several reports of this recently. We have a theory. Investigating now. I've found a cause of this for SVN users. We have had a report from a Git user which I've not been able to reproduce yet. Fix coming shortly. Created attachment 52940 [details]
Patch
Comment on attachment 52940 [details]
Patch
Yay! Thanks for fixing this bug.
+ # FIXME: This should probably use cwd=self.checkout_root.
We should use checkout_root in all these cases to make SCM more predictable and aligned between SVN and GIT.
Comment on attachment 52940 [details]
Patch
I agree. I'll file a bug about that.
Filed bug 37346 for followup. Comment on attachment 52940 [details] Patch Clearing flags on attachment: 52940 Committed r57361: <http://trac.webkit.org/changeset/57361> All reviewed patches have been landed. Closing bug. |