|Summary:||webkit-patch attached my patch to the wrong bug|
|Product:||WebKit||Reporter:||Steve Falkenburg <sfalken>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, commit-queue, ericu, eric|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Steve Falkenburg 2010-04-02 00:23:43 PDT
I filed <https://bugs.webkit.org/show_bug.cgi?id=37014> using webkit-patch. I used: - webkit-prepare - webkit-upload When I uploaded the patch, I edited the changelog a bit (you can see it in the patch). The webkit-patch tool attached the patch to this bug instead: https://bugs.webkit.org/show_bug.cgi?id=36971
Comment 1 Eric Seidel (no email) 2010-04-02 14:30:31 PDT
I'm not sure I know what webkit-prepare or webkit-upload are? Are those internal Apple scripts?
Comment 2 Eric Seidel (no email) 2010-04-02 14:31:13 PDT
I expect he means: webkit-patch prepare webkit-patch upload
Comment 3 Steve Falkenburg 2010-04-02 20:35:01 PDT
Correct. I used: webkit-patch prepare webkit-patch upload No Apple scripts.
Comment 4 Eric Seidel (no email) 2010-04-08 21:56:14 PDT
*** Bug 37107 has been marked as a duplicate of this bug. ***
Comment 5 Eric Seidel (no email) 2010-04-08 21:56:35 PDT
We've had several reports of this recently. We have a theory. Investigating now.
Comment 6 Eric Seidel (no email) 2010-04-08 22:49:02 PDT
I've found a cause of this for SVN users. We have had a report from a Git user which I've not been able to reproduce yet. Fix coming shortly.
Comment 8 Adam Barth 2010-04-09 07:22:28 PDT
Comment on attachment 52940 [details] Patch Yay! Thanks for fixing this bug. + # FIXME: This should probably use cwd=self.checkout_root. We should use checkout_root in all these cases to make SCM more predictable and aligned between SVN and GIT.
Comment 9 Eric Seidel (no email) 2010-04-09 11:31:15 PDT
Comment on attachment 52940 [details] Patch I agree. I'll file a bug about that.
Comment 11 WebKit Commit Bot 2010-04-09 14:01:45 PDT
Comment on attachment 52940 [details] Patch Clearing flags on attachment: 52940 Committed r57361: <http://trac.webkit.org/changeset/57361>
Comment 12 WebKit Commit Bot 2010-04-09 14:01:51 PDT
All reviewed patches have been landed. Closing bug.