Bug 36641
Summary: | [DRT/Chromium] Remove Chrome code dependency as possible | ||
---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | fishd |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Other | ||
OS: | All | ||
Bug Depends on: | 35902, 43312, 43396, 43403, 43472, 45016, 45091, 45517 | ||
Bug Blocks: | 28395 |
Kent Tamura
We should get rid of dependency on base/ net/ and so on in WebKitTools/DumpRenderTree/chromium/*.
They should be expanded, or should add wrapper functions to webkit_support.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Kent Tamura
There are some comments on this topic from fishd:
http://codereview.chromium.org/1331001/diff/11002/42007
Kent Tamura
Now DRT code depends on no Chromium code other than webkit/support/webkit_support*.h though it depends on V8/Skia/GogoleURL. I think we may close this bug.