Bug 45517 – [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kent Tamura]

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h

[Kent Tamura]

Created attachment 67146 [details]
Patch

[WebKit Review Bot]

Attachment 67146 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:39:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tony Chang]

Comment on attachment 67146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67146&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40
> +#include "webkit/support/webkit_support_gfx.h"
>  #include <algorithm>
Is the style checker just complaining about not including ImageDiff.h?  Seems fine to ignore.

[Kent Tamura]

(In reply to comment #3)
> > WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40
> > +#include "webkit/support/webkit_support_gfx.h"
> >  #include <algorithm>
> Is the style checker just complaining about not including ImageDiff.h?  Seems fine to ignore.

Yes.  It's ignorable.

[Kent Tamura]

Comment on attachment 67146 [details]
Patch

Clearing flags on attachment: 67146

Committed r67363: <http://trac.webkit.org/changeset/67363>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.