Bug 45517 - [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
Summary: [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 36641
  Show dependency treegraph
 
Reported: 2010-09-09 20:01 PDT by Kent Tamura
Modified: 2010-09-12 21:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.17 KB, patch)
2010-09-09 20:06 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-09-09 20:01:44 PDT
[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
Comment 1 Kent Tamura 2010-09-09 20:06:14 PDT
Created attachment 67146 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-09 20:09:10 PDT
Attachment 67146 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:39:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tony Chang 2010-09-10 09:49:55 PDT
Comment on attachment 67146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67146&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40
> +#include "webkit/support/webkit_support_gfx.h"
>  #include <algorithm>
Is the style checker just complaining about not including ImageDiff.h?  Seems fine to ignore.
Comment 4 Kent Tamura 2010-09-12 21:20:22 PDT
(In reply to comment #3)
> > WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40
> > +#include "webkit/support/webkit_support_gfx.h"
> >  #include <algorithm>
> Is the style checker just complaining about not including ImageDiff.h?  Seems fine to ignore.

Yes.  It's ignorable.
Comment 5 Kent Tamura 2010-09-12 21:21:35 PDT
Comment on attachment 67146 [details]
Patch

Clearing flags on attachment: 67146

Committed r67363: <http://trac.webkit.org/changeset/67363>
Comment 6 Kent Tamura 2010-09-12 21:21:43 PDT
All reviewed patches have been landed.  Closing bug.