Bug 45091 - [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
Summary: [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 36641
  Show dependency tree / graph
 
Reported: 2010-09-01 23:53 PDT by Kent Tamura
Modified: 2010-09-02 18:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (27.40 KB, patch)
2010-09-02 00:53 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-09-01 23:53:11 PDT 
[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
Comment 1 Kent Tamura 2010-09-02 00:53:47 PDT 
Created attachment 66337 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-09-02 07:34:40 PDT 
Comment on attachment 66337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66337&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/Task.h:40
> +class WebTask {
Minor quibble: the Web prefix is typically used in WebKit layer. How about we call it something like DRTTask. Blergh, that's bad too! Ok, I am out of ideas -- you can land as-is :)
Comment 3 Kent Tamura 2010-09-02 18:50:36 PDT 
(In reply to comment #2)
> (From update of attachment 66337 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66337&action=prettypatch
> 
> > WebKitTools/DumpRenderTree/chromium/Task.h:40
> > +class WebTask {
> Minor quibble: the Web prefix is typically used in WebKit layer. How about we call it something like DRTTask. Blergh, that's bad too! Ok, I am out of ideas -- you can land as-is :)

I'll commit the patch as is.
We can rename it easily later :-)
Comment 4 Kent Tamura 2010-09-02 18:51:34 PDT 
Comment on attachment 66337 [details]
Patch

Clearing flags on attachment: 66337

Committed r66701: <http://trac.webkit.org/changeset/66701>
Comment 5 Kent Tamura 2010-09-02 18:51:41 PDT 
All reviewed patches have been landed.  Closing bug.