RESOLVED FIXED Bug 45091
[DRT/Chromium] Remove dependency to base/task.h and base/timer.h 
https://bugs.webkit.org/show_bug.cgi?id=45091
Summary [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
Kent Tamura
Reported 2010-09-01 23:53:11 PDT
[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
Attachments
Patch (27.40 KB, patch)
2010-09-02 00:53 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-09-02 00:53:47 PDT
Created attachment 66337 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-09-02 07:34:40 PDT
Comment on attachment 66337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66337&action=prettypatch > WebKitTools/DumpRenderTree/chromium/Task.h:40 > +class WebTask { Minor quibble: the Web prefix is typically used in WebKit layer. How about we call it something like DRTTask. Blergh, that's bad too! Ok, I am out of ideas -- you can land as-is :)
Kent Tamura
Comment 3 2010-09-02 18:50:36 PDT
(In reply to comment #2) > (From update of attachment 66337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=66337&action=prettypatch > > > WebKitTools/DumpRenderTree/chromium/Task.h:40 > > +class WebTask { > Minor quibble: the Web prefix is typically used in WebKit layer. How about we call it something like DRTTask. Blergh, that's bad too! Ok, I am out of ideas -- you can land as-is :) I'll commit the patch as is. We can rename it easily later :-)
Kent Tamura
Comment 4 2010-09-02 18:51:34 PDT
Comment on attachment 66337 [details] Patch Clearing flags on attachment: 66337 Committed r66701: <http://trac.webkit.org/changeset/66701>
Kent Tamura
Comment 5 2010-09-02 18:51:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.