Bug 36186

Summary: [Qt] Multiselect Popup - adjusting QtAbstractWebPopup
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth, koivisto
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 36178    
Bug Blocks: 36368    
Attachments:
Description Flags
patch 1
none
patch 2 none

Description Luiz Agostini 2010-03-16 13:41:51 PDT 
QtAbstractWebPopup must provide new methods to be used by its descendants that wish to handle <select multiple> elements.
Comment 1 Luiz Agostini 2010-03-16 14:02:32 PDT 
Created attachment 50834 [details]
patch 1
Comment 2 Luiz Agostini 2010-03-19 11:41:54 PDT 
Created attachment 51174 [details]
patch 2
Comment 3 Kenneth Rohde Christiansen 2010-03-19 21:35:34 PDT 
Comment on attachment 51174 [details]
patch 2

I assume this doesn't break normal non-multiple selects as valueChanged() is not never being called. Please confirm that before adding this to the cq.
Comment 4 Tor Arne Vestbø 2010-03-22 06:36:58 PDT 
Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs
Comment 5 Luiz Agostini 2010-03-22 10:15:15 PDT 
(In reply to comment #3)
> (From update of attachment 51174 [details])
> I assume this doesn't break normal non-multiple selects as valueChanged() is
> not never being called. Please confirm that before adding this to the cq.

It doesn't. :)
Comment 6 WebKit Commit Bot 2010-03-22 10:38:53 PDT 
Comment on attachment 51174 [details]
patch 2

Clearing flags on attachment: 51174

Committed r56341: <http://trac.webkit.org/changeset/56341>
Comment 7 WebKit Commit Bot 2010-03-22 10:38:58 PDT 
All reviewed patches have been landed.  Closing bug.