Bug 36186

Summary: [Qt] Multiselect Popup - adjusting QtAbstractWebPopup
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth, koivisto
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 36178    
Bug Blocks: 36368    
Attachments:
Description Flags
patch 1
none
patch 2 none

Luiz Agostini
Reported 2010-03-16 13:41:51 PDT
QtAbstractWebPopup must provide new methods to be used by its descendants that wish to handle <select multiple> elements.
Attachments
patch 1 (2.99 KB, patch)
2010-03-16 14:02 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (3.15 KB, patch)
2010-03-19 11:41 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-03-16 14:02:32 PDT
Created attachment 50834 [details] patch 1
Luiz Agostini
Comment 2 2010-03-19 11:41:54 PDT
Created attachment 51174 [details] patch 2
Kenneth Rohde Christiansen
Comment 3 2010-03-19 21:35:34 PDT
Comment on attachment 51174 [details] patch 2 I assume this doesn't break normal non-multiple selects as valueChanged() is not never being called. Please confirm that before adding this to the cq.
Tor Arne Vestbø
Comment 4 2010-03-22 06:36:58 PDT
Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs
Luiz Agostini
Comment 5 2010-03-22 10:15:15 PDT
(In reply to comment #3) > (From update of attachment 51174 [details]) > I assume this doesn't break normal non-multiple selects as valueChanged() is > not never being called. Please confirm that before adding this to the cq. It doesn't. :)
WebKit Commit Bot
Comment 6 2010-03-22 10:38:53 PDT
Comment on attachment 51174 [details] patch 2 Clearing flags on attachment: 51174 Committed r56341: <http://trac.webkit.org/changeset/56341>
WebKit Commit Bot
Comment 7 2010-03-22 10:38:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.