Bug 34675

Summary: check-webkit-style: Move ProcessorOptions, ArgumentPrinter, and ArgumentParser classes into a separate file
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 34674    
Bug Blocks: 34677    
Attachments:
Description Flags
Proposed patch none

Chris Jerdonek
Reported 2010-02-05 23:07:36 PST
The new file can be called something like parser.py.
Attachments
Proposed patch (60.06 KB, patch)
2010-02-18 14:12 PST, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-02-06 14:08:24 PST
It makes more sense to split the class before moving, because then there will be less code to move, and there will be fewer dependencies to carry over in that initial move.
Chris Jerdonek
Comment 2 2010-02-18 14:12:43 PST
Created attachment 49041 [details] Proposed patch The additional unit tests I added were to cover development-testing errors that occurred when running "check-webkit-style" but that did not occur when running "test-webkitpy".
Shinichiro Hamaji
Comment 3 2010-02-18 18:59:58 PST
Comment on attachment 49041 [details] Proposed patch Looks good. Hmm... it was a bit difficult to check code move change with bugzilla. Eventually we may want to have better diff pretty printer.
WebKit Commit Bot
Comment 4 2010-02-18 21:17:10 PST
Comment on attachment 49041 [details] Proposed patch Clearing flags on attachment: 49041 Committed r55001: <http://trac.webkit.org/changeset/55001>
WebKit Commit Bot
Comment 5 2010-02-18 21:17:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.