Bug 34674

Summary: check-webkit-style: Divide ProcessorOptions class into two classes
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 34932    
Bug Blocks: 34675    
Attachments:
Description Flags
Proposed patch
none
Proposed patch 2 hamaji: review+, commit-queue: commit-queue-

Chris Jerdonek
Reported 2010-02-05 23:02:47 PST
Divide the ProcessorOptions class into a CheckWebKitStyleOptions class and a CheckerConfiguration class, per the FIXME's in checker.py.
Attachments
Proposed patch (72.11 KB, patch)
2010-02-12 13:38 PST, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
Proposed patch 2 (55.52 KB, patch)
2010-02-17 07:01 PST, Chris Jerdonek 		hamaji: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-02-12 13:38:58 PST
Created attachment 48660 [details] Proposed patch Sorry for the length! This patch has no new functionality. The test coverage is pretty much the same.
Shinichiro Hamaji
Comment 2 2010-02-14 22:00:51 PST
> Sorry for the length! This patch has no new functionality. The test coverage > is pretty much the same. Looks OK, but I cannot be sure. Could you split this patch? Code cleanup done in this patch seems to be great (thanks!) but is somehow big. If possible, I'd like to review the refactoring work separately.
Chris Jerdonek
Comment 3 2010-02-15 00:49:01 PST
(In reply to comment #2) > > Sorry for the length! This patch has no new functionality. The test coverage > > is pretty much the same. > > Looks OK, but I cannot be sure. Could you split this patch? Code cleanup done > in this patch seems to be great (thanks!) but is somehow big. If possible, I'd > like to review the refactoring work separately. Sure, thanks. I'll do the clean-up here first: https://bugs.webkit.org/show_bug.cgi?id=34932
Shinichiro Hamaji
Comment 4 2010-02-15 23:39:47 PST
Comment on attachment 48660 [details] Proposed patch > Sure, thanks. I'll do the clean-up here first Thanks, It will help me a lot! Clearing r? flag to wait the cleanup effort.
Chris Jerdonek
Comment 5 2010-02-17 07:01:27 PST
Created attachment 48901 [details] Proposed patch 2
Shinichiro Hamaji
Comment 6 2010-02-17 20:58:35 PST
Comment on attachment 48901 [details] Proposed patch 2 Looks good!
WebKit Commit Bot
Comment 7 2010-02-17 23:09:14 PST
Comment on attachment 48901 [details] Proposed patch 2 Rejecting patch 48901 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Shinichiro Hamaji', '--force']" exit_code: 1 Last 500 characters of output: bKitTools/Scripts/webkitpy/style/checker_unittest.py Hunk #10 FAILED at 514. Hunk #11 succeeded at 670 (offset 1 line). 1 out of 11 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/checker_unittest.py.rej patching file WebKitTools/Scripts/webkitpy/style/error_handlers.py patching file WebKitTools/Scripts/webkitpy/style/error_handlers_unittest.py patching file WebKitTools/Scripts/webkitpy/style/filter.py patching file WebKitTools/Scripts/webkitpy/style/filter_unittest.py Full output: http://webkit-commit-queue.appspot.com/results/282171
Chris Jerdonek
Comment 8 2010-02-17 23:31:14 PST
Manually committed after rebasing: http://trac.webkit.org/changeset/54934 (Commit-queue errors resulted from: https://bugs.webkit.org/show_bug.cgi?id=34971 )
Note You need to log in before you can comment on or make changes to this bug.