Bug 33917

Summary: [Chromium] "ChromiumBridge" should be also accessible as "PlatformBridge"
Product: WebKit Reporter: Andrei Popescu <andreip>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Bug Depends on:    
Bug Blocks: 33608, 33673    
Attachments:
Description Flags
Add PlatformBridge.h header. none

Andrei Popescu
Reported 2010-01-20 12:55:56 PST
A better name for ChromiumBridge is PlatformBridge. This is because, on Chromium, it is the client that provides some of the functionality that is normally provided by the underlying operating system (or platform). This functionality is accessible via the ChromiumBridge class, so the word "Chromium" is used where "Platform" is actually meant. Android already uses PlatformBridge in a similar way to how Chromium uses ChromiumBridge. Therefore, an added benefit of renaming ChromiumBridge to PlatformBridge is that the two ports, Android and Chromium, will share code without the need for any #ifdefs. We therefore aim to rename ChromiumBridge to PlatformBridge. For now, we will add the PlatformBridge.h header and just typedef ChromiumBridge PlatformBridge. This is what this bug tracks. When the Android port is fully upstreamed, we will rename ChromiumBridge to PlatformBridge and merge it with Android's version. This will be tracked in a separate bug. Patch coming soon.
Attachments
Add PlatformBridge.h header. (3.10 KB, patch)
2010-01-20 13:15 PST, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2010-01-20 13:15:55 PST
Created attachment 47056 [details] Add PlatformBridge.h header.
WebKit Commit Bot
Comment 2 2010-01-21 11:01:36 PST
Comment on attachment 47056 [details] Add PlatformBridge.h header. Clearing flags on attachment: 47056 Committed r53633: <http://trac.webkit.org/changeset/53633>
WebKit Commit Bot
Comment 3 2010-01-21 11:01:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.