Bug 32901

Summary: valueAsDate setter Part 1: millisecond -> ISODateTime conversion
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasdate
Bug Depends on:    
Bug Blocks: 32697, 32915    
Attachments:
Description Flags
Proposed patch mjs: review-

Kent Tamura
Reported 2009-12-23 08:08:29 PST
In order to implement HTMLInputElement::setValueAsDate, we need to implement 1. millisecond double value to ISODateTime conversion 2. ISODateTime to String conversion This bug handles the step 1 above.
Attachments
Proposed patch (15.63 KB, patch)
2009-12-23 08:30 PST, Kent Tamura 		mjs: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2009-12-23 08:30:25 PST
Created attachment 45441 [details] Proposed patch
WebKit Review Bot
Comment 2 2009-12-23 08:35:32 PST
style-queue ran check-webkit-style on attachment 45441 [details] without any errors.
Maciej Stachowiak
Comment 3 2009-12-28 02:12:27 PST
This patch lacks tests. Perhaps it is only testable in combination with part 2, in which case I'd rather see the two combined into one patch with tests included.
Maciej Stachowiak
Comment 4 2009-12-28 02:13:32 PST
Comment on attachment 45441 [details] Proposed patch r- per comment above
Kent Tamura
Comment 5 2009-12-29 08:52:50 PST
Ok, I'm making testable patches. I have made a new bug, Bug#33021.
Note You need to log in before you can comment on or make changes to this bug.