Bug 32901

Summary: valueAsDate setter Part 1: millisecond -> ISODateTime conversion
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasdate
Bug Depends on:    
Bug Blocks: 32697, 32915    
Description Flags
Proposed patch mjs: review-

Description Kent Tamura 2009-12-23 08:08:29 PST
In order to implement HTMLInputElement::setValueAsDate, we need to implement
 1. millisecond double value to ISODateTime conversion
 2. ISODateTime to String conversion

This bug handles the step 1 above.
Comment 1 Kent Tamura 2009-12-23 08:30:25 PST
Created attachment 45441 [details]
Proposed patch
Comment 2 WebKit Review Bot 2009-12-23 08:35:32 PST
style-queue ran check-webkit-style on attachment 45441 [details] without any errors.
Comment 3 Maciej Stachowiak 2009-12-28 02:12:27 PST
This patch lacks tests. Perhaps it is only testable in combination with part 2, in which case I'd rather see the two combined into one patch with tests included.
Comment 4 Maciej Stachowiak 2009-12-28 02:13:32 PST
Comment on attachment 45441 [details]
Proposed patch

r- per comment above
Comment 5 Kent Tamura 2009-12-29 08:52:50 PST
Ok, I'm making testable patches.

I have made a new bug, Bug#33021.