Bug 31853

Summary:

bugzilla-tool should have a mark-fixed command

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ddkilzer, mjs

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	eric: review+

Eric Seidel (no email)

Reported 2009-11-24 16:49:56 PST

bugzilla-tool should have a mark-fixed command I'm not sure it entirely fits with the current model, but there is the occasional time when you need to commit by hand and it's nice to have bugzilla-tool be able to mark the bug you just commited as fixed/closed. This could be an "uncommon" command not shown in the standard --help.

Attachments
Patch (1.46 KB, patch) 2009-11-24 19:05 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch (1.39 KB, patch) 2009-11-25 18:12 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch (1.31 KB, patch) 2009-11-25 18:19 PST, Adam Barth	eric: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-11-24 18:37:24 PST

This is like a five line patch with LandingSequence. Basically, you just want to run the last step of the landing sequence.

Adam Barth

Comment 2 2009-11-24 19:04:12 PST

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 3 2009-11-24 19:04:33 PST

Guess it works. :)

Adam Barth

Comment 4 2009-11-24 19:05:23 PST

Created attachment 43825 [details] Patch

Eric Seidel (no email)

Comment 5 2009-11-24 20:27:51 PST

Comment on attachment 43825 [details] Patch "All reviewed patches have been landed" seems wrong for this. Maybe we should prompt for a reason?

Adam Barth

Comment 6 2009-11-24 22:39:50 PST

Maybe it shouldn't leave a comment at all? Maybe it should prompt for a revision number?

Eric Seidel (no email)

Comment 7 2009-11-25 07:09:07 PST

We could just make "REASON" a required argument. We could have it confirm that it had found the right bug/revision combo by showing you the bug title. It could/should also update the bug with the correct revision number and trac link. I think a version of this which simply required a REASON argument would be a fine first-step though. :)

Adam Barth

Comment 8 2009-11-25 18:07:52 PST

Comment on attachment 43825 [details] Patch I think Eric wanted to R- this patch.

Adam Barth

Comment 9 2009-11-25 18:11:55 PST

This is not really fixed.

Adam Barth

Comment 10 2009-11-25 18:12:26 PST

Created attachment 43885 [details] Patch

Adam Barth

Comment 11 2009-11-25 18:13:01 PST

openzored

Adam Barth

Comment 12 2009-11-25 18:19:17 PST

Created attachment 43886 [details] Patch

Adam Barth

Comment 13 2009-11-25 18:25:39 PST

Committed r51404: <http://trac.webkit.org/changeset/51404>

David Kilzer (:ddkilzer)

Comment 14 2009-12-02 07:59:36 PST

See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed.

Adam Barth

Comment 15 2009-12-02 09:57:24 PST

(In reply to comment #14) > See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed. Holy duplicated code, Batman!

Adam Barth

Comment 16 2009-12-02 10:00:21 PST

Follow up in https://bugs.webkit.org/show_bug.cgi?id=32073

Note You need to log in before you can comment on or make changes to this bug.