Bug 28916
| Summary: | patches marked cq+ without review will hang the commit-queue | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
patches marked cq+ without review will hang the commit-queue
The queue spins infinitely. It thinks it has something to land, but then when it goes to land it, it doesn't find a patch and thus it just loops indefinitely. :(
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
https://bugs.webkit.org/show_bug.cgi?id=28887 caused the hang this evening.
Eric Seidel (no email)
This will be fixed by the patch on bug 28605. The fix was to make the commit queue call the fetch_patches_from_commit_queue up front instead of fetch_bug_ids_from_commit_queue so that it is sure to validate the patches before passing them off to land-patches.
*** This bug has been marked as a duplicate of bug 28605 ***