Bug 285569
| Summary: | Add test so that bug 285568 can't happen again | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=285595 | ||
Jean-Yves Avenard [:jya]
In https://bugs.webkit.org/show_bug.cgi?id=285568 , we reverted https://bugs.webkit.org/show_bug.cgi?id=283172 as it broke a major web site (Duolingo).
The change in 283172 prevented a call to `MediaPlayer::play()` if we were in the middle of a seek (it had exception to bypass the new logic) if currentTime was >= duration which isn't sufficient, currentTime could be at 0 if we do seek to 0 -> play()
Having play() being called and acted upon during seek() is allowed by the spec.
If GStreamer has an issue there, it should be handled in MediaPlayerPrivateGStreamer rather than in HTMLMediaElement.
We need a test so that any future change as done in bug 283172 can't happen again.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/142517881>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/38710
EWS
Committed 288590@main (4bdbf870a50a): <https://commits.webkit.org/288590@main>
Reviewed commits have been landed. Closing PR #38710 and removing active labels.