| Summary: | commit-queue mode for bugzilla-tool | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ddkilzer, eric | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 27970 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Barth
2009-07-31 23:00:19 PDT
Created attachment 33932 [details]
commit-queue script
Here's the script i'm using. Could probably use some iteration.
Sometimes patch requires user interaction. There doesn't to be an obvious flag that does what we want. --batch is close, but it will assume the patch is reversed if it appears that way, which is kind of like an automated rollout... Also, failing tests pop up safari, which needs to be closed. The build bots must have a flag that suppresses this behavior. More investigation needed. Created attachment 34032 [details]
Work in progress
Comment on attachment 34032 [details]
Work in progress
Worked at least for a simple test case.
Comment on attachment 34032 [details] Work in progress We could key this choice off of an option some day: 6 for bug_id in bug_ids: 147 print "%s" % tool.bugs.bug_url_for_bug_id(bug_id) 147 print "%s" % bug_id Danger Danger will robinson! 366 options.force_clean = True I don't think we should --force-clean automagically. Seems we should check the value of ['commit-queue'] here: 239 if 'commit-queue' in attachment and not attachment['is_obsolete']: attachment.get('commit-queue', False) might do the trick. I think ['commit-queue'] might throw an exception. Otherwise looks good. We need to fix the "destroying your current work state" problem by forcing --force-clean. We need to require something to be passed before we go destroying data. You should be aware of the proposed refactoring in: https://bugs.webkit.org/show_bug.cgi?id=26715 (I really should split out the refactoring bits into a separate patch and get it landed.) Created attachment 34036 [details]
Patch v1
Comment on attachment 34036 [details]
Patch v1
Oops. Didn't mean to obsolete this patch.
Comment on attachment 34036 [details] Patch v1 Seems you should combine this with teh one I just reviewed. No sense in adding the command only to remove it again. 217 attachment['commit-queue'] = True # FIXME: Validate that the flag was set by a committer. validation is possible as soon as bug 27972 is reviewed. Otherwise this looks great! Committed revision 46751. |