Bug 277057
| Summary: | Make writing-mode/direction/TextFlow conditional checks consistent, efficient, and correct | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | fantasai <fantasai.bugs> |
| Component: | Layout and Rendering | Assignee: | fantasai <fantasai.bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 166941 | ||
fantasai
We currently have a ton of ad-hoc checks for writing-mode and direction in our codebase, each following their own pattern of boolean operators, temporary variables, and conditional statements. This makes the code harder to read, and more likely to contain errors.
We should instead have RenderStyle return a WritingMode object (similar to Gecko's) that encapsulates all of the relevant CSS style information and that has convenience methods to easily, efficiently, and correctly return the specific resolved information that layout code tends to query.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/132446895>
fantasai
Pull request: https://github.com/WebKit/WebKit/pull/32026
EWS
Committed 285555@main (72e07604aff9): <https://commits.webkit.org/285555@main>
Reviewed commits have been landed. Closing PR #32026 and removing active labels.
Tim Nguyen (:ntim)
*** Bug 276028 has been marked as a duplicate of this bug. ***
Tim Nguyen (:ntim)
*** Bug 260036 has been marked as a duplicate of this bug. ***