Bug 265363
| Summary: | Decouple BitmapImage sources and main functions into separate classes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=271979 https://bugs.webkit.org/show_bug.cgi?id=271977 https://bugs.webkit.org/show_bug.cgi?id=274478 https://bugs.webkit.org/show_bug.cgi?id=275999 https://bugs.webkit.org/show_bug.cgi?id=277495 https://bugs.webkit.org/show_bug.cgi?id=278593 https://bugs.webkit.org/show_bug.cgi?id=279221 |
||
| Bug Depends on: | 268127, 267254, 267570, 267571, 267607, 268184, 269626, 271977 | ||
| Bug Blocks: | |||
Said Abou-Hallawa
This class is needlessly complicated which makes it difficult to hack. It handles
1. NativeImage and ImageSource images
2. Static and animated images
3. Async and sync image decoding
It also supports lots of testing APIs and tuning and corner cases. What we need is a simple and clear design interface which splits these cases and tuning nicely. This will make changing the class a lot easier in the future.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118819338>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/20916
EWS
Committed 274746@main (055031e5c8a8): <https://commits.webkit.org/274746@main>
Reviewed commits have been landed. Closing PR #20916 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 269626
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/24678
EWS
Committed 276827@main (8b78e07f7be5): <https://commits.webkit.org/276827@main>
Reviewed commits have been landed. Closing PR #24678 and removing active labels.
Said Abou-Hallawa
*** Bug 268184 has been marked as a duplicate of this bug. ***