Bug 261242
| Summary: | [git-webkit] Add screen-reader friendly review wizard | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, andresg_22, ap, dewei_zhu, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 261246, 261277, 263652, 263653, 273781, 273784 | ||
| Bug Blocks: | |||
Jonathan Bedard
HTML based code review tools are not friendly for blind developers. This was true in bugzilla, although GitHub's review interface is a regression. It seems that other HTML review tools (notably, Bitbucket) have this same problem.
Andres Gonzalez and I proto-typed a text-based command-line review wizard that he was able to utilize to great effect last week. We should clean up and land the code for that wizard.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/115083100>
Jonathan Bedard
Proto-type uploaded in https://github.com/WebKit/WebKit/pull/17187, although that change needs to be divided up to be landed.
Jonathan Bedard
*** Bug 273123 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/27628
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/28389
EWS
Committed 279244@main (26ef083bdcb3): <https://commits.webkit.org/279244@main>
Reviewed commits have been landed. Closing PR #27628 and removing active labels.
EWS
Committed 279255@main (74313d0521aa): <https://commits.webkit.org/279255@main>
Reviewed commits have been landed. Closing PR #28389 and removing active labels.