Bug 258437
| Summary: | Attachment: Move image display from legacy to modern implementation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | HTML Editing | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 251830 | ||
| Bug Blocks: | 258844, 267838 | ||
Gerald Squelart
Replace the inner legacy attachment with a standard `<img>` element.
<rdar://105252742>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/15228
EWS
Committed 265615@main (b0e7ef7b0420): <https://commits.webkit.org/265615@main>
Reviewed commits have been landed. Closing PR #15228 and removing active labels.
Gerald Squelart
Re-opening for pull request https://github.com/WebKit/WebKit/pull/15421
EWS
Committed 265629@main (61d2643b6fe6): <https://commits.webkit.org/265629@main>
Reviewed commits have been landed. Closing PR #15421 and removing active labels.
Jonathan Bedard
Looks like this flakily regressed fast/attachment/cocoa/wide-attachment-folder-icon.html
Jonathan Bedard
https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-folder-icon.html
Gerald Squelart
Thank you Jonathan.
I believe it may have made a few wide-attachment-* tests flaky, because of the way the icon is asynchronously fetched and then loaded into an img.
I'm working on bug 258865, which should solve this.