Bug 252076
| Summary: | Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=252064 | ||
| Bug Depends on: | |||
| Bug Blocks: | 269799 | ||
David Kilzer (:ddkilzer)
Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig.
They aren't used anywhere inside WebKit, and they haven't been kept up-to-date after `WK_IOS_17` was added, so they likely aren't used any longer.
Referring to these Xcode variables in Configurations/WebKitTargetConditionals.xcconfig:
'''
WK_IOS_13_14 = $(WK_IOS_13_14_$(WK_IOS_BEFORE_13));
WK_IOS_13_14_ = $(WK_IOS_14);
WK_IOS_13_14_YES = _IOS_BEFORE_13;
WK_IOS_13_15 = $(WK_IOS_13_15_$(WK_IOS_BEFORE_13));
WK_IOS_13_15_ = $(WK_IOS_15);
WK_IOS_13_15_YES = _IOS_BEFORE_13;
WK_IOS_13_16 = $(WK_IOS_13_16_$(WK_IOS_BEFORE_13));
WK_IOS_13_16_ = $(WK_IOS_16);
WK_IOS_13_16_YES = _IOS_BEFORE_13;
[...]
WK_IOS_14_15 = $(WK_IOS_14_15_$(WK_IOS_BEFORE_14));
WK_IOS_14_15_ = $(WK_IOS_15);
WK_IOS_14_15_YES = _IOS_BEFORE_14;
WK_IOS_14_16 = $(WK_IOS_14_16_$(WK_IOS_BEFORE_14));
WK_IOS_14_16_ = $(WK_IOS_16);
WK_IOS_14_16_YES = _IOS_BEFORE_14;
[...]
WK_IOS_15_16 = $(WK_IOS_15_16_$(WK_IOS_BEFORE_15));
WK_IOS_15_16_ = $(WK_IOS_16);
WK_IOS_15_16_YES = _IOS_BEFORE_15;
[...]
WK_IOS_16_17 = $(WK_IOS_16_17_$(WK_IOS_BEFORE_16));
WK_IOS_16_17_ = $(WK_IOS_17);
WK_IOS_16_17_YES = _IOS_BEFORE_16;
'''
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105295734>
David Kilzer (:ddkilzer)
BTW, the existence of these variables may have lead to this apparent copy-paste mistake:
Fix mistakes in WebKitTargetConditionals.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=252064
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/9947
EWS
Committed 260514@main (093c15d17e01): <https://commits.webkit.org/260514@main>
Reviewed commits have been landed. Closing PR #9947 and removing active labels.