Bug 245108
| Summary: | Remove unused PlatformMouseEvent::modifierFlags() and m_modifierFlags | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abifox, achristensen, sam, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 47651, 171297, 257175 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Add type for PlatformMouseEvent modifier flags.
Only Mac and Windows actually use modifier flags on the PlatformMouseEvent object and AFAICT:
- The `unsigned` type is not big enough for either the `NSEventModifierFlags` type on macOS or the `WPARAM` type on Windows.
- The instance variable is never used on iOS/tvOS/watchOS platforms.
- The lack of type may have caused conversion to the wrong enum value in the fix for Bug 171297 (188192@main).
Need to check with some experts what MacCatalyst should do in these cases.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/99850228>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/4293
David Kilzer (:ddkilzer)
Bug 257175 (Use OptionSet<PlatformEventModifier> instead of raw modifier flags in WebCore/page/Chrome) removed the last uses of `PlatformMouseEvent::m_modifierFlags` and `PlatformMouseEvent::modifierFlags()`, making it dead code.
This field was replaced with `OptionSet<PlatformEventModifier>` in Bug 257175.
Instead of defining and using a cross-platform type, we can just delete the code now!
EWS
Committed 310567@main (c559ef21e247): <https://commits.webkit.org/310567@main>
Reviewed commits have been landed. Closing PR #4293 and removing active labels.