Bug 239885

Summary:	Use the same simulated iPhone model for layout tests an API tests
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	gsnedders, jbedard, ryanhaddad, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=231844 https://bugs.webkit.org/show_bug.cgi?id=256806

Simon Fraser (smfr)

Reported 2022-04-28 21:36:25 PDT

It's confusing that we use iPhone 12 Pro for layout tests, but iPhone 8 for API tests (bug 239867). We need to standardize on one of them.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-04-28 21:37:38 PDT

<rdar://problem/92505373>

Sam Sneddon [:gsnedders]

Comment 2 2022-04-29 07:58:16 PDT

It was bug 231844 which moved LayoutTests from iPhone SE to iPhone 12 (non-Pro). I'm a bit confused about what's going on with API tests, it looks like it should similarly be using the defaults specified in Tools/Scripts/webkitpy/port/ios_simulator.py?

Ryan Haddad

Comment 3 2022-08-05 13:10:58 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3055

Jonathan Bedard

Comment 4 2023-05-15 14:58:04 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13897

EWS

Comment 5 2023-05-16 07:43:20 PDT

Committed 264115@main (4518454316d9): <https://commits.webkit.org/264115@main> Reviewed commits have been landed. Closing PR #13897 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.