Bug 237311

Summary: Unable to set logging channel levels through NSUserDefaults in Release builds
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit Misc.Assignee: Kimmo Kinnunen <kkinnunen>
Status: ASSIGNED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233360
https://bugs.webkit.org/show_bug.cgi?id=227822
Attachments:
Description Flags
Patch jer.noble: review-

Kimmo Kinnunen
Reported 2022-03-01 00:35:14 PST
Unable to set logging channel levels through NSUserDefaults in Release builds Regressed in bug 233360 Jer Noble 2022-02-24 20:02:47 PST > In bug 227822, we showed that logLevelString() returns the empty string for release builds. This patch undid that change, and returned the previous behavior of effectively disabling all non-error logging in release builds, affecting our ability to collect debug logs with a NSUserDefaults change.
Attachments
Patch (13.60 KB, patch)
2022-03-01 01:13 PST, Kimmo Kinnunen 		jer.noble: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-03-01 01:13:33 PST
Created attachment 453479 [details] Patch
Jer Noble
Comment 2 2022-03-01 10:40:39 PST
Lets not do this. We've have regressions in process launch time in the past that were due to reading NSDefaults during process launch.
Jer Noble
Comment 3 2022-03-01 10:44:19 PST
Comment on attachment 453479 [details] Patch Moving from r+ to r-; reading NSDefaults during process launch has caused process launch time regressions in the past. See bug #185951 for context. With the change from r290654 in place, we should only be reading NSDefaults once during app launch, then never again, so this change should be unnecessary.
Radar WebKit Bug Importer
Comment 4 2022-03-08 00:36:15 PST
<rdar://problem/89954192>
Note You need to log in before you can comment on or make changes to this bug.