Bug 236202

Summary: [WASM] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WasmLLIntGenerator.cpp
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229114
https://bugs.webkit.org/show_bug.cgi?id=236181
https://bugs.webkit.org/show_bug.cgi?id=236459
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2022-02-06 10:08:23 PST 
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WasmLLIntGenerator.cpp.

This occurs in the JSC::Wasm::LLIntGenerator::ControlType() constructor.

Found by clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2022-02-06 10:09:01 PST 
<rdar://problem/88545940>
Comment 2 David Kilzer (:ddkilzer) 2022-02-06 10:09:50 PST 
Created attachment 451042 [details]
Patch v1
Comment 3 Yusuke Suzuki 2022-02-06 11:15:27 PST 
Comment on attachment 451042 [details]
Patch v1

r=me
Comment 4 David Kilzer (:ddkilzer) 2022-02-06 11:19:19 PST 
Comment on attachment 451042 [details]
Patch v1

Marking cq+ since enough builds/tests passed to verify this small change.
Comment 5 EWS 2022-02-06 12:05:28 PST 
Committed r289175 (246870@main): <https://commits.webkit.org/246870@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451042 [details].