Bug 236202

Summary: [WASM] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WasmLLIntGenerator.cpp
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229114
https://bugs.webkit.org/show_bug.cgi?id=236181
https://bugs.webkit.org/show_bug.cgi?id=236459
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2022-02-06 10:08:23 PST
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WasmLLIntGenerator.cpp. This occurs in the JSC::Wasm::LLIntGenerator::ControlType() constructor. Found by clang static analyzer.
Attachments
Patch v1 (1.55 KB, patch)
2022-02-06 10:09 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-06 10:09:01 PST
<rdar://problem/88545940>
David Kilzer (:ddkilzer)
Comment 2 2022-02-06 10:09:50 PST
Created attachment 451042 [details] Patch v1
Yusuke Suzuki
Comment 3 2022-02-06 11:15:27 PST
Comment on attachment 451042 [details] Patch v1 r=me
David Kilzer (:ddkilzer)
Comment 4 2022-02-06 11:19:19 PST
Comment on attachment 451042 [details] Patch v1 Marking cq+ since enough builds/tests passed to verify this small change.
EWS
Comment 5 2022-02-06 12:05:28 PST
Committed r289175 (246870@main): <https://commits.webkit.org/246870@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451042 [details].
Note You need to log in before you can comment on or make changes to this bug.