Bug 232843

Summary: [GPU Process] [Filters 14/23] Apply the filter to an ImageBuffer through GraphicsContext and ImageBuffer
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, heycam, kondapallykalyan, macpherson, menard, pdr, ryuan.choi, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233611
Bug Depends on:    
Bug Blocks: 231253    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
heycam: review+
Patch none

Description Said Abou-Hallawa 2021-11-08 13:18:54 PST 
This will make it possible to record applying the filter for GPUProcess.
Comment 1 Radar WebKit Bug Importer 2021-11-15 13:23:10 PST 
<rdar://problem/85426291>
Comment 2 Said Abou-Hallawa 2021-11-27 13:43:08 PST 
Created attachment 445223 [details]
Patch
Comment 3 Said Abou-Hallawa 2021-11-27 14:16:50 PST 
Created attachment 445224 [details]
Patch
Comment 4 Said Abou-Hallawa 2021-11-27 19:14:35 PST 
Created attachment 445228 [details]
Patch
Comment 5 Said Abou-Hallawa 2021-11-27 21:14:32 PST 
Created attachment 445231 [details]
Patch
Comment 6 Said Abou-Hallawa 2021-11-28 11:50:02 PST 
Created attachment 445240 [details]
Patch
Comment 7 Said Abou-Hallawa 2021-11-28 19:41:03 PST 
Created attachment 445247 [details]
Patch
Comment 8 Said Abou-Hallawa 2021-11-28 19:53:51 PST 
Comment on attachment 445240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445240&action=review

> Source/WebCore/rendering/CSSFilter.cpp:401
> +    effect->transformResultColorSpace(DestinationColorSpace::SRGB());

This call is not needed since the caller which is Filter::apply() will transform the returned FilterImage to sRGB. This is fixed in the latest patch.
Comment 9 EWS 2021-11-28 22:08:34 PST 
Committed r286203 (244585@main): <https://commits.webkit.org/244585@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445247 [details].